feat: get a family #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robertbeal
commented
Jun 17, 2024
robertbeal
commented
- Get a family (which is made up of members, devices and some other props)
- Map the API response into a Family class
cdnninja
reviewed
Jun 18, 2024
|
|
||
| self.members = [ | ||
| Member( | ||
| createdAt=datetime.fromisoformat(member["createdAt"].rstrip("Z")), |
There was a problem hiding this comment.
Well this is simpler than my current approach to both data and dataclass!
cdnninja
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Only note is that to consume this I think something should be added to yoto_manager to store the data and manage it.
Other item is that using the replace approach which I think it does today this can't be used by home assistant as the memory object will change on refresh, vs updating current variables. Maybe not important though since this data doesn't change often
|
I added the method to yoto manager and init so I can merge. Thanks for adding this method! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.