Add compatibility/arrow-functions-feature lint #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
requested changes
Jan 18, 2025
| impl Rule for ArrowFunctionsFeatureRule { | ||
| fn get_definition(&self) -> RuleDefinition { | ||
| RuleDefinition::enabled("Arrow Functions Feature", Level::Error) | ||
| .with_maximum_supported_php_version(PHPVersion::PHP73) |
There was a problem hiding this comment.
Suggested change
| .with_maximum_supported_php_version(PHPVersion::PHP73) | |
| .with_maximum_supported_php_version(PHPVersion::PHP74) |
azjezz
reviewed
Jan 18, 2025
| .with_description(indoc! {" | ||
| Flags any usage of the `fn` keyword for arrow functions, which was introduced in PHP 7.4. | ||
|
|
||
| In environments running older versions of PHP, you can use the `use` keyword to import variables instead. |
There was a problem hiding this comment.
Suggested change
| In environments running older versions of PHP, you can use the `use` keyword to import variables instead. | |
| In environments running older versions of PHP, you can use an anonymous function | |
| with `use` keyword anonymous functions combined with the `use` keyword to import variables instead. |
| In environments running older versions of PHP, you can use the `use` keyword to import variables instead. | ||
| "}) | ||
| .with_example(RuleUsageExample::valid( | ||
| "Using the `use` keyword for arrow functions", |
There was a problem hiding this comment.
Suggested change
| "Using the `use` keyword for arrow functions", | |
| "Using an anonymous function with `use` keyword", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt at writing a lint!
In order to test it out properly, the
MINIMUM_PHP_VERSIONneeds to be lowered toPHP73since arrow functions are available on PHP 7.4+. (note: there is currently an issue with "Null Coalesce Assignment Feature" that warns forphp_version = "7.4"see more info here: 95a84ce#r151496707)mago/src/consts.rs
Line 52 in dc32663
I have done that locally, and the lint seems to be working! 🎉