Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add kfp-ui test case in repo level integration tests #253

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

tests: add kfp-ui test case in repo level integration tests #253

wants to merge 11 commits into from

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Jul 14, 2023 •
edited
Loading

Add a test case for reaching kfp-ui and getting back a 200 response.

NOTE: merge after #261

@DnPlas DnPlas requested a review from a team as a code owner July 14, 2023 11:12
@i-chvets
Copy link
Contributor

i-chvets commented Jul 18, 2023 •
edited
Loading

Looks good. Bundle tests are failing in build charm.

i-chvets
i-chvets previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@i-chvets i-chvets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@DnPlas
Copy link
Contributor Author

DnPlas commented Jul 19, 2023 •
edited
Loading

The bundle integration test seems to be failing because of #243, will re-trigger the CI once again.

i-chvets
i-chvets approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@i-chvets i-chvets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-chvets i-chvets i-chvets approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DnPlas @i-chvets