Skip to content

Commit

Permalink
Pin charmcraft channel to 3.1/stable (#565)
Browse files Browse the repository at this point in the history
* Pin charmcraft channel

* Update .github/workflows/integrate.yaml

Co-authored-by: Daniela Plascencia <[email protected]>

* Add comment above the pinning to link to the proper issue

* Pin to 3.x instead of 3.1 which doesn't exist as a track

---------

Co-authored-by: Daniela Plascencia <[email protected]>
  • Loading branch information
mvlassis and DnPlas authored Sep 4, 2024
1 parent d5082ed commit e3bdcdf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/integrate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ jobs:
provider: microk8s
channel: 1.29-strict/stable
juju-channel: 3.4/stable
charmcraft-channel: latest/candidate
# Pinned to 3.x/stable due to https://github.com/canonical/charmcraft/issues/1845
charmcraft-channel: 3.x/stable

- name: Integration tests
run: |
Expand Down Expand Up @@ -139,7 +140,8 @@ jobs:
provider: microk8s
channel: 1.29-strict/stable
juju-channel: 3.4/stable
charmcraft-channel: latest/candidate
# Pinned to 3.x/stable due to https://github.com/canonical/charmcraft/issues/1845
charmcraft-channel: 3.x/stable
microk8s-addons: "dns hostpath-storage rbac metallb:10.64.140.43-10.64.140.49"

- name: Run test
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,5 @@ jobs:
charm-path: ${{ matrix.charm-path }}
channel: ${{ steps.parse-inputs.outputs.destination_channel }}
tag-prefix: ${{ steps.parse-inputs.outputs.tag_prefix }}
charmcraft-channel: latest/candidate
# Pinned to 3.x/stable due to https://github.com/canonical/charmcraft/issues/1845
charmcraft-channel: 3.x/stable

0 comments on commit e3bdcdf

Please sign in to comment.