Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add migration guide for tasklist endpoints #4756

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nathansandi
Copy link
Contributor

@nathansandi nathansandi commented Dec 12, 2024

Description

Provide the migration guide from Tasklist endpoint

  • All task endpoints / Update as well the User Task input/output attributes
  • Forms
  • Variables

closes camunda/camunda#23740

When should this change go live?

This can be live as soon as it is approved, as it is related to the next version and the feature is already present in alphass

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Contributor

github-actions bot commented Dec 12, 2024

👋 🤖 🤔 Hello, @tmetzke! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/apis-tools/migration-manuals/migrate-to-camunda-api.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@nathansandi nathansandi requested a review from a team December 12, 2024 13:24
@nathansandi nathansandi added 8.7.0-alpha3 January 2024 alpha release component:docs Documentation improvements, including new or updated content labels Dec 12, 2024
@nathansandi nathansandi marked this pull request as ready for review December 12, 2024 13:28
@nathansandi nathansandi requested a review from tmetzke January 3, 2025 13:28
@tmetzke tmetzke added the deploy Stand up a temporary docs site with this PR label Jan 9, 2025
@github-actions github-actions bot temporarily deployed to camunda-docs January 9, 2025 12:59 Destroyed
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not done yet, but here is my first take on the review (there simply are a lot of things to look at and compare 😅).

General

  • The headings should probably be aligned with the ones users can find in the APIs currently, i.e. „Tasklist API" > "Entity (e.g., Task, Form, Variables)" > "Endpoint (e.g., Save draft variables, Search task variables, Search tasks, ...)“
  • Also the endpoint names should be identical to the old ones in V1 so they can easily be found in the guide (we can even link from the V1 endpoints to the respective guide header later maybe, @christinaausley, in a note or something, saying "Updating to V2 API? See guide here!"?)
  • The endpoints could be arranged in the same order they have in the respective V1 API spec OR alphabetically (or we align both of them to be alphabetically, migration guide and V1)
  • I would suggest to list the change, e.g. "attribute removed|renamed|added|type changed", followed by bullet points explaining what to do and potentially a reasoning (e.g., when something was removed without replacement)

Get form endpoint

Improvements to the endpoint itself (should go into the OpenAPI spec as a follow-up)

PR suggestions (this PR here)

  •  We should explain why the form endpoint was split up. Previously, you could find a form by its ID but that is not possible anymore

Search task variables endpoint

Improvements to the endpoint itself (should go into the OpenAPI spec as a follow-up)

PR suggestions (this PR here)

  •  Maybe link to unified response structure details from above if possible (not sure if this works because it's inside a tab item, @christinaausley?)
  •  id renamed to variableKey (you currently say it's replaced but is that correct?)
  •  isValueTruncated renamed to isTruncated
  •  previewValue renamed to value (is that true, can you check, @nathansandi?)
  •  value renamed to fullValue (is that true, can you check, @nathansandi?)
  •  scopeKey added
  •  processInstanceKey added
  •  tenantId added

Search tasks

Improvements to the endpoint itself (should go into the OpenAPI spec as a follow-up)

PR suggestions (this PR here)

  •  More details on request structure changes
    •  pageSize now limit inside page
    •  searchAfterOrEqual and searchBeforeOrEqual removed
    •  searchAfter and searchBefore now inside page
  •  taskVariables removed
    •  Split up into processInstanceVariables and localVariables
    •  We need to explain the reasoning for this
  •  priority type changed
    • Can be an integer (equals filter semantics) or advanced search (slightly different to what you can do in V1, e.g., multiple conditions are possible now, operator names are slightly different)
  •  When we added followUpDate and dueDate in the endpoint filters (which we should do), they still have to be used differently (advanced search using gte and lte instead of from and to)

I will continue this review tomorrow, feel free to start with adjustments and creating follow-up issues for the OpenAPI changes we should make. Thank you for all the work here so far, @nathansandi, I know it's a lot of content but it will majorly help users migrating properly ⭐

@nathansandi
Copy link
Contributor Author

The follow-up issues were created:

camunda/camunda#26744
camunda/camunda#26745
camunda/camunda#26746

@akeller
Copy link
Member

akeller commented Jan 13, 2025

@nathansandi what's the status of this PR? Will it go out with alpha3? I see conflicting info in the PR description and discussions.

@tmetzke tmetzke removed the 8.7.0-alpha3 January 2024 alpha release label Jan 14, 2025
@tmetzke
Copy link
Member

tmetzke commented Jan 14, 2025

That's on me, sorry, forgot to update this one. It can go out whenever, doesn't have to be in alpha3. I'll rework this week to finish this as @nathansandi needed to help out somewhere else.

@tmetzke tmetzke assigned tmetzke and unassigned nathansandi Jan 14, 2025
Copy link
Contributor

🚧 The preview environment for the commit 136cf37 is being built. This usually takes 15-20 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user task endpoints' changes
4 participants