-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add migration guide for tasklist endpoints #4756
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 🤔 Hello, @tmetzke! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not done yet, but here is my first take on the review (there simply are a lot of things to look at and compare 😅).
General
- The headings should probably be aligned with the ones users can find in the APIs currently, i.e. „Tasklist API" > "Entity (e.g., Task, Form, Variables)" > "Endpoint (e.g., Save draft variables, Search task variables, Search tasks, ...)“
- Also the endpoint names should be identical to the old ones in V1 so they can easily be found in the guide (we can even link from the V1 endpoints to the respective guide header later maybe, @christinaausley, in a note or something, saying "Updating to V2 API? See guide here!"?)
- The endpoints could be arranged in the same order they have in the respective V1 API spec OR alphabetically (or we align both of them to be alphabetically, migration guide and V1)
- I would suggest to list the change, e.g. "
attribute
removed|renamed|added|type changed", followed by bullet points explaining what to do and potentially a reasoning (e.g., when something was removed without replacement)
Get form endpoint
Improvements to the endpoint itself (should go into the OpenAPI spec as a follow-up)
-
bpmnId
instead oftitle
is worse than before, maybe we should stick withtitle
in the V2 API - RenamebpmnId
toformId
on REST API form responses camunda#26911 - The description of
schema
can be improved toThe form content
- fix: update get form schema descriptions camunda#26754 - In general, the descriptions we have in the Tasklist V1 API are a lot more elaborate, let’s reuse them in V2 more - fix: update get form schema descriptions camunda#26754
PR suggestions (this PR here)
- We should explain why the form endpoint was split up. Previously, you could find a form by its ID but that is not possible anymore
Search task variables endpoint
Improvements to the endpoint itself (should go into the OpenAPI spec as a follow-up)
-
variableNames
should be added as a filter - feat: add variable name filter for the user task variable query camunda#26798
PR suggestions (this PR here)
- Maybe link to unified response structure details from above if possible (not sure if this works because it's inside a tab item, @christinaausley?)
-
id
renamed tovariableKey
(you currently say it's replaced but is that correct?) -
isValueTruncated
renamed toisTruncated
-
previewValue
renamed tovalue
(is that true, can you check, @nathansandi?) -
value
renamed tofullValue
(is that true, can you check, @nathansandi?) -
scopeKey
added -
processInstanceKey
added -
tenantId
added
Search tasks
Improvements to the endpoint itself (should go into the OpenAPI spec as a follow-up)
-
followUpDate
anddueDate
are missing as filter options - feat: add support for followUpDate and dueDate filters camunda#26751
PR suggestions (this PR here)
- More details on request structure changes
-
pageSize
nowlimit
insidepage
-
searchAfterOrEqual
andsearchBeforeOrEqual
removed -
searchAfter
andsearchBefore
now insidepage
-
-
taskVariables
removed- Split up into
processInstanceVariables
andlocalVariables
- We need to explain the reasoning for this
- Split up into
-
priority
type changed- Can be an integer (equals filter semantics) or advanced search (slightly different to what you can do in V1, e.g., multiple conditions are possible now, operator names are slightly different)
- When we added
followUpDate
anddueDate
in the endpoint filters (which we should do), they still have to be used differently (advanced search usinggte
andlte
instead offrom
andto
)
I will continue this review tomorrow, feel free to start with adjustments and creating follow-up issues for the OpenAPI changes we should make. Thank you for all the work here so far, @nathansandi, I know it's a lot of content but it will majorly help users migrating properly ⭐
The follow-up issues were created: camunda/camunda#26744 |
@nathansandi what's the status of this PR? Will it go out with alpha3? I see conflicting info in the PR description and discussions. |
That's on me, sorry, forgot to update this one. It can go out whenever, doesn't have to be in alpha3. I'll rework this week to finish this as @nathansandi needed to help out somewhere else. |
🚧 The preview environment for the commit 136cf37 is being built. This usually takes 15-20 minutes. |
Description
Provide the migration guide from Tasklist endpoint
closes camunda/camunda#23740
When should this change go live?
This can be live as soon as it is approved, as it is related to the next version and the feature is already present in alphass
PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).