Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring25 M3 r2.1 #135

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

FabrizioMoggio
Copy link
Collaborator

@FabrizioMoggio FabrizioMoggio commented Jan 2, 2025

NOTE: NOT COMPLETED. YAML still not included.

This PR is the final PR for Spiring25 M3.

What type of PR is this?

  • documentation
  • release management

What this PR does / why we need it:

The PR updates all the file in terms of release number referring to r2.1 and version v1.0.0-rc.1.
Updates the CHANGELOG.md file

Which issue(s) this PR fixes:

Spring25 scope: #114
Release number update: #136
CHANGELOG file: #128

Including the improvement from the last release, so far.
bigludo7
bigludo7 previously approved these changes Jan 6, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I guess we need to add @camaraproject/release-management_maintainers as reviewer ?

@hdamker
Copy link
Contributor

hdamker commented Jan 6, 2025

@FabrizioMoggio content looks good, but two comments regarding the release process:

  • There is no such thing as a release 2.0, the correct number would be 2.1 (first release of the second cycle)
  • The update of the CHANGELOG should be part of the release PR (the one PR which is merged just before the release). Otherwise you have information in the CHANGELOG about a release which is not there. In worst case you would even need to update the CHANGELOG for the release before the actual release date.

For the second point I propose to extend the current PR towards a complete release PR for r2.1, including setting the version in the YAML, updating the API-Readiness-Checklist (based on updated template) etc

BTW: please correct the filename of the checklist from call-forwarding-signal-API-Readiness-Checklistst.md into call-forwarding-signal-API-Readiness-Checklist.md

@FabrizioMoggio
Copy link
Collaborator Author

Considering the comments from @hdamker, I will extend this PR to be the release PR. Including the consolidated YAML with just the release number updated and all the consolidated files updating them to r2.1.

@FabrizioMoggio FabrizioMoggio changed the title Changelog for r2.0 Sprin25 M3 Jan 7, 2025
@FabrizioMoggio FabrizioMoggio mentioned this pull request Jan 7, 2025
@hdamker hdamker changed the title Sprin25 M3 Spring25 M3 r2.1 Jan 7, 2025
CHANGELOG.md Outdated
Comment on lines 44 to 52
* Call Forwarding Service "state" terminology updated: https://github.com/camaraproject/CallForwardingSignal/issues/111
* Alignment with CAMARA Guidelines in info.description:
* https://github.com/camaraproject/CallForwardingSignal/issues/120
* https://github.com/camaraproject/CallForwardingSignal/issues/122
* https://github.com/camaraproject/CallForwardingSignal/issues/122
* https://github.com/camaraproject/CallForwardingSignal/issues/130
* Enhancements and Alignments in Errors: https://github.com/camaraproject/CallForwardingSignal/issues/119
* Align API-Testing with CAMARA Guidelines:
* https://github.com/camaraproject/CallForwardingSignal/issues/123
* https://github.com/camaraproject/CallForwardingSignal/issues/134
* https://github.com/camaraproject/CallForwardingSignal/issues/134
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please list the actual PRs which have introduced the changes instead of the issues (see other repositories for examples). Issues are sometimes pivoting during the work on the PRs (and don't get updated then). Relevant for readers of the CHANGELOG are the actual PRs, as the details of the PRs (the commits) are showing the actual changes.

@hdamker
Copy link
Contributor

hdamker commented Jan 7, 2025

@FabrizioMoggio Please add @camaraproject/release-management_maintainers when the PR is ready for review by the Release Management team.

- listed PRs instead of issues
- reference to r2.1
This was referenced Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants