-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring25 M3 r2.1 #135
base: main
Are you sure you want to change the base?
Spring25 M3 r2.1 #135
Conversation
Including the improvement from the last release, so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I guess we need to add @camaraproject/release-management_maintainers as reviewer ?
@FabrizioMoggio content looks good, but two comments regarding the release process:
For the second point I propose to extend the current PR towards a complete release PR for r2.1, including setting the version in the YAML, updating the API-Readiness-Checklist (based on updated template) etc BTW: please correct the filename of the checklist from call-forwarding-signal-API-Readiness-Checklistst.md into call-forwarding-signal-API-Readiness-Checklist.md |
Considering the comments from @hdamker, I will extend this PR to be the release PR. Including the consolidated YAML with just the release number updated and all the consolidated files updating them to r2.1. |
CHANGELOG.md
Outdated
* Call Forwarding Service "state" terminology updated: https://github.com/camaraproject/CallForwardingSignal/issues/111 | ||
* Alignment with CAMARA Guidelines in info.description: | ||
* https://github.com/camaraproject/CallForwardingSignal/issues/120 | ||
* https://github.com/camaraproject/CallForwardingSignal/issues/122 | ||
* https://github.com/camaraproject/CallForwardingSignal/issues/122 | ||
* https://github.com/camaraproject/CallForwardingSignal/issues/130 | ||
* Enhancements and Alignments in Errors: https://github.com/camaraproject/CallForwardingSignal/issues/119 | ||
* Align API-Testing with CAMARA Guidelines: | ||
* https://github.com/camaraproject/CallForwardingSignal/issues/123 | ||
* https://github.com/camaraproject/CallForwardingSignal/issues/134 | ||
* https://github.com/camaraproject/CallForwardingSignal/issues/134 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please list the actual PRs which have introduced the changes instead of the issues (see other repositories for examples). Issues are sometimes pivoting during the work on the PRs (and don't get updated then). Relevant for readers of the CHANGELOG are the actual PRs, as the details of the PRs (the commits) are showing the actual changes.
@FabrizioMoggio Please add @camaraproject/release-management_maintainers when the PR is ready for review by the Release Management team. |
- listed PRs instead of issues - reference to r2.1
NOTE: NOT COMPLETED. YAML still not included.
This PR is the final PR for Spiring25 M3.
What type of PR is this?
What this PR does / why we need it:
The PR updates all the file in terms of release number referring to r2.1 and version v1.0.0-rc.1.
Updates the CHANGELOG.md file
Which issue(s) this PR fixes:
Spring25 scope: #114
Release number update: #136
CHANGELOG file: #128