Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up docker.yml workflow #47

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Set up docker.yml workflow #47

merged 1 commit into from
Jul 25, 2024

Conversation

yinchi
Copy link
Collaborator

@yinchi yinchi commented Jul 25, 2024

Squashing previous commits (see https://stackabuse.com/git-squash-multiple-commits-in-to-one-commit/):

  • Add docker.yml workflow
  • Remove poetry.lock from Dockerfiles
    • This is because these files are in .gitignore and our GitHub Action will not work if these files are requested.
  • Bugfix: update docker.yml -- Add login step
  • Bugfix: update docker.yml -- Add permissions
  • Add --no-root to Dockerfiles
    • This is because we do not copy the project files to the build until after Poetry is run.

- Add docker.yml workflow

- Remove poetry.lock from Dockerfiles

 -  This is because these files are in .gitignore and our GitHub Action will not work if these files are requested.

- Bugfix: update docker.yml -- Add login step

- Bugfix: update docker.yml -- Add permissions

- Add --no-root to Dockerfiles

  - This is because we do not copy the project files to the build until
after Poetry is run.
@yinchi yinchi changed the title Squash the commits below: Set up docker.yml workflow Jul 25, 2024
@yinchi
Copy link
Collaborator Author

yinchi commented Jul 25, 2024

This PR partially addresses #45 .

@yinchi yinchi merged commit a4e01b1 into main Jul 25, 2024
@yinchi yinchi deleted the yinchi-dev branch July 25, 2024 15:30
@yinchi yinchi mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant