Fixed problematic function #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified code completely: needs to be checked
lobisquit
changed the title
|
@lobisquit You algorithm seems more efficient. I review my own code and think about it for a few days. Still can't recall why I gave an extra projection from points on line to the line itself. What a shame!!! Anyway, your improvement is reasonable. Thank you. |
|
Perfect then. Thank you very much for the library by the way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
point_projects_to_linefunction has been rewritten, as a workaround for #5.Now it seems to work on my dataset, but needs another pair of eyes in order to be sure it does what it is intended to.