This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Update plugin.py #114
Open
Update plugin.py #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the plugin to work with Icecast 2.4.x (tested with Icecast 2.4.4). 1) Line 107 - Removed the `[0]` due to JSON output changes. 2) Line 117 and 141 replaced inexistent `artist` key in the actual JSON format by `server_name` key (the actual DJ).
We should rely only on track name for track changes announcement since we have no `artist` key and `server_name` can be streaming for hours
|
@butterscotchstallion could you please the pending PRs? would be great to people having something working with newer icecast versions tho. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the plugin to work with Icecast 2.4.x (tested with Icecast 2.4.4).
[0]due to JSON output changes.artistkey in the actual JSON format byserver_namekey (the actual DJ).Thanks to cottongin and pinkieval for the help in #limnoria @ Freenode