Replace GetContainingDigests() with VirtualApply() #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to add a common interface for Leaf and InitialContentsFetcher. I think the best name for that is InitialNode, but that name is already taken. Rename the existing InitialNode type to InitialChild, which is a better fit, because it's based on Child.
At the call site we could just check the return value of VirtualApply() to see whether this operation is actually implemented by the files in question.
Right now we have completely different code paths for computing the containing digests for files and directories. For files we call LinkableLeaf.VirtualApply(), while for directories we call InitialContentsFetcher.GetContainingDigests(). The downside of the current approach is that generic virtual file system APIs are strongly coupled against REv2. By giving InitialContentsFetcher a VirtualApply(), we get rid of the coupling. In addition to that, it's now possible to call InitialChild.GetNode().VirtualApply() to obtain the set of containing digests in a file type oblivious way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have completely different code paths for computing the containing digests for files and directories. For files we call LinkableLeaf.VirtualApply(), while for directories we call InitialContentsFetcher.GetContainingDigests().
The downside of the current approach is that generic virtual file system APIs are strongly coupled against REv2. By giving InitialContentsFetcher a VirtualApply(), we get rid of the coupling. In addition to that, it's now possible to call InitialChild.GetNode().VirtualApply() to obtain the set of containing digests in a file type oblivious way.