Skip to content

Commit

Permalink
Log failure to close and remove build directory
Browse files Browse the repository at this point in the history
There is no real way to forward directory deletion errors when an
execution has failed as it would cover the main error. Therefore, print
it as a log.
  • Loading branch information
moroten committed Dec 18, 2024
1 parent d03d5e3 commit 652e52e
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion pkg/builder/local_build_executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package builder

import (
"context"
"log"
"os"
"sync"
"time"
Expand Down Expand Up @@ -114,7 +115,11 @@ func (be *localBuildExecutor) CheckReadiness(ctx context.Context) error {
if err != nil {
return util.StatusWrap(err, "Failed to get build directory")
}
defer buildDirectory.Close()
defer func() {
if err := buildDirectory.Close(); err != nil {
log.Printf("Failed to close build directory %s: %s", buildDirectoryPath.GetUNIXString(), err)
}
}()

// Create a useless directory inside the build directory. The
// runner will validate that it exists.
Expand Down Expand Up @@ -166,6 +171,7 @@ func (be *localBuildExecutor) Execute(ctx context.Context, filePool re_filesyste
attachErrorToExecuteResponse(
response,
util.StatusWrap(err, "Failed to close build directory"))
log.Printf("Failed to close build directory %s: %s", buildDirectoryPath.GetUNIXString(), err)
}
}()

Expand Down

0 comments on commit 652e52e

Please sign in to comment.