Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

231 timestamp shortcuts jump for tagging #266

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

231 timestamp shortcuts jump for tagging #266

wants to merge 2 commits into from

Conversation

krish1925
Copy link
Collaborator

Added a jump to button that either takes milliseconds, or a combination of minutes and seconds. This allows taggers to jump to a certain time in the videoplayer.

@krish1925 krish1925 changed the base branch from main to development January 14, 2025 02:07
Fredenck
Fredenck requested changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@Fredenck Fredenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks almost good. is it possible to set the default of the mins/seconds to an integer, 0, rather than the empty string ""? For example, if I only fill the minute to 7 and press jump, it won't jump (I'd need to put minute to 7 and seconds to 0).

@krish1925 krish1925 requested a review from Fredenck January 18, 2025 10:25
@krish1925
Copy link
Collaborator Author

Made the new changes, lmk if anything else is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fredenck Fredenck Awaiting requested review from Fredenck

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krish1925 @Fredenck