Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

121 fix undo button in tagger #252

Merged
merged 3 commits into from
Dec 1, 2024
Merged

121 fix undo button in tagger #252

merged 3 commits into from
Dec 1, 2024

Conversation

bzhang102
Copy link
Collaborator

image

Closes #121

  • Added popUp to fields tracked by taggerHistory
  • Fixed issue of saveHistory creating shallow copies of table with JSON.stringify
  • Cleaned up misc things

@bzhang102 bzhang102 self-assigned this Nov 25, 2024
@bzhang102 bzhang102 linked an issue Nov 25, 2024 that may be closed by this pull request
Fix undo button in tagger #121
Closed
Fredenck
Fredenck approved these changes Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@Fredenck Fredenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, both functionality and code-wise. Looks clean!

@Fredenck Fredenck merged commit d96a9fd into development Dec 1, 2024
@Fredenck Fredenck deleted the 121-fix-undo-button-in-tagger branch December 1, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fredenck Fredenck Fredenck approved these changes

@awest25 awest25 Awaiting requested review from awest25

Assignees

@bzhang102 bzhang102

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix undo button in tagger
2 participants
@bzhang102 @Fredenck