More empty/spacing fixes #2262
More empty/spacing fixes #2262
Conversation
…NOT a LaTeX name), and to only trim explicit spaces, not spacing commands
…n case that's actually needed
…has peculiar, specific needs
…or the content when checking emptiness and related tests
…pacing added around alignment columns
…lignment rows/columns that contain spaces if bordered; prepare for CSS padding to deal with spacing
…a specific column
…; use to determine css; simplify \lx@intercol and its usage
|
A lot of tweaks, tuning, and subtle changes; the result is generally much more accurate spacing & padding on various tabular and |
…acing within groups
…ertical size of l/rpadding
|
OK, that should do it; tikz works again. |
| <td align="left" thead="column"><text font="bold">Entity</text></td> | ||
| <td align="left" thead="column"><text font="bold">Unicode Name</text></td> | ||
| <td align="left" thead="column"><text font="bold">Unicode</text></td> | ||
| <td align="left" thead="column"> <text font="bold">Entity</text></td> |
There was a problem hiding this comment.
Are the added lead-in spaces in {supertabular} cells an intended change?
There was a problem hiding this comment.
Yep, intended; the spaces account for the "unusual" cell padding in the test cases; spaces were expedient vs some clever css scheme. (comment applies to other cases)
| <td align="left" class="ltx_nopad_r">[a]</td> | ||
| <td align="left" class="ltx_nopad_r">(b)</td> | ||
| <td align="left" class="ltx_nopad_r"> {c}</td> | ||
| <td align="left" class="ltx_nopad_r"> [d]</td> |
There was a problem hiding this comment.
Hm, this is quite a large amount of new lead-in padding for cells {c} and [d]. Intended?
| <td align="left">b</td> | ||
| </tr> | ||
| <tr> | ||
| <td align="left">c –</td> | ||
| <td align="left">c –</td> |
There was a problem hiding this comment.
Wasn't the new space here meant for the other side of the dash?
There was a problem hiding this comment.
I'm thinking that one of the spaces is due to an \hfil, which should get taken care of separately/eventually.
lib/LaTeXML/Package.pm
Outdated
| return 0 unless ($thing->getDefinition eq $STATE->lookupDefinition(T_BEGIN)) | ||
| && IsEmpty($thing->getBody->unlist); } } } | ||
| # Sneaky Whatsit property for something (an arg) that stands-in for the whatsit's content. | ||
| if (my $body = $thing->getProperty('the_body')) { |
There was a problem hiding this comment.
the_body isn't a very evocative name. I think we had come up with an alternative that had the word box. Was it content_box ?
There was a problem hiding this comment.
Ah, yeah; that's the name we came up with; done!
Some tweaks dealing with "emptiness" and spaces. LaTeX tabular (& related) will trim only explicit spaces from the rhs of columns, but not space producing things (like
\phantom).IsEmptyno longer considers spaces to be empty, but there's a newIsEmptyOrSpaceif that's needed.Fixes #1999
A WiP as I may sneak in some further fixes.