Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty cells #2250

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Empty cells #2250

merged 2 commits into from
Oct 31, 2023

Conversation

brucemiller
Copy link
Owner

Alignment cells should have both zero width and height to be considered empty (except for rule lines).

Fixes #1861

@brucemiller brucemiller requested a review from dginev October 26, 2023 14:13
dginev
dginev approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@dginev dginev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@brucemiller brucemiller merged commit faa73d9 into master Oct 31, 2023
26 checks passed
@brucemiller brucemiller deleted the empty-cells branch October 31, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dginev dginev dginev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disappearing makebox of zero width
2 participants
@brucemiller @dginev