Skip to content

Commit

Permalink
Fixed Chart Y-Axis Color
Browse files Browse the repository at this point in the history
  • Loading branch information
brminnick committed May 24, 2020
1 parent a9244fb commit 697dd57
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 71 deletions.
37 changes: 0 additions & 37 deletions GitTrends.UITests/Pages/TrendsPage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ public TrendsPage(IApp app) : base(app)

public bool IsEmptyDataViewVisible => App.Query(_emptyDataView).Any();

AppResult ViewsLegendIcon => App.Query(GenerateMarkedQuery(TrendsChartConstants.TotalViewsTitle)).Last();
AppResult UniqueViewsLegendIcon => App.Query(GenerateMarkedQuery(TrendsChartConstants.UniqueViewsTitle)).Last();
AppResult ClonesLegendIcon => App.Query(GenerateMarkedQuery(TrendsChartConstants.TotalClonesTitle)).Last();
AppResult UniqueClonesLegendIcon => App.Query(GenerateMarkedQuery(TrendsChartConstants.UniqueClonesTitle)).Last();

public override Task WaitForPageToLoad(TimeSpan? timespan = null)
{
try
Expand Down Expand Up @@ -114,38 +109,6 @@ public void TapUniqueClonesCard()
App.Screenshot("Unique Clones Card Tapped");
}

public void TapViewsLegendIcon()
{
var rect = ViewsLegendIcon.Rect;

App.TapCoordinates(rect.CenterX, rect.CenterY);
App.Screenshot("Views Legend Icon Tapped");
}

public void TapUniqueViewsLegendIcon()
{
var rect = UniqueViewsLegendIcon.Rect;

App.TapCoordinates(rect.CenterX, rect.CenterY);
App.Screenshot("Unique Views Legend Icon Tapped");
}

public void TapClonesLegendIcon()
{
var rect = ClonesLegendIcon.Rect;

App.TapCoordinates(rect.CenterX, rect.CenterY);
App.Screenshot("Clones Legend Icon Tapped");
}

public void TapUniqueClonesLegendIcon()
{
var rect = UniqueClonesLegendIcon.Rect;

App.TapCoordinates(rect.CenterX, rect.CenterY);
App.Screenshot("Unique Clones Legend Icon Tapped");
}

public void TapReferringSitesButton()
{
App.Tap(_referringSiteButton);
Expand Down
34 changes: 0 additions & 34 deletions GitTrends.UITests/Tests/TrendsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -67,39 +67,5 @@ public void EnsureCardsAreInteractive()
//Assert
Assert.AreNotEqual(isUniqueClonesSeriesVisible_Initial, TrendsPage.IsSeriesVisible(TrendsChartConstants.UniqueClonesTitle));
}

[Test]
public void EnsureLegendIsInteractive()
{
//Arrange
bool isViewsSeriesVisible_Initial = TrendsPage.IsSeriesVisible(TrendsChartConstants.TotalViewsTitle);
bool isUniqueViewsSeriesVisible_Initial = TrendsPage.IsSeriesVisible(TrendsChartConstants.UniqueViewsTitle);
bool isClonesSeriesVisible_Initial = TrendsPage.IsSeriesVisible(TrendsChartConstants.TotalClonesTitle);
bool isUniqueClonesSeriesVisible_Initial = TrendsPage.IsSeriesVisible(TrendsChartConstants.UniqueClonesTitle);

//Act
TrendsPage.TapViewsLegendIcon();

//Assert
Assert.AreNotEqual(isViewsSeriesVisible_Initial, TrendsPage.IsSeriesVisible(TrendsChartConstants.TotalViewsTitle));

//Act
TrendsPage.TapUniqueViewsLegendIcon();

//Assert
Assert.AreNotEqual(isUniqueViewsSeriesVisible_Initial, TrendsPage.IsSeriesVisible(TrendsChartConstants.UniqueViewsTitle));

//Act
TrendsPage.TapClonesLegendIcon();

//Assert
Assert.AreNotEqual(isClonesSeriesVisible_Initial, TrendsPage.IsSeriesVisible(TrendsChartConstants.TotalClonesTitle));

//Act
TrendsPage.TapUniqueClonesLegendIcon();

//Assert
Assert.AreNotEqual(isUniqueClonesSeriesVisible_Initial, TrendsPage.IsSeriesVisible(TrendsChartConstants.UniqueClonesTitle));
}
}
}
1 change: 1 addition & 0 deletions GitTrends/Views/Trends/TrendsChart.cs
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public Chart()
FontSize = 12,
FontFamily = FontFamilyConstants.RobotoRegular,
};
secondaryAxisLabelStyle.SetDynamicResource(ChartLabelStyle.TextColorProperty, nameof(BaseTheme.ChartAxisTextColor));

SecondaryAxis = new NumericalAxis
{
Expand Down

0 comments on commit 697dd57

Please sign in to comment.