Restrict usage of assembly code to little endian for ARM & AAarch64. #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2221 +/- ##
==========================================
- Coverage 97.03% 97.03% -0.01%
==========================================
Files 161 161
Lines 20388 20415 +27
Branches 458 458
==========================================
+ Hits 19784 19810 +26
Misses 495 495
- Partials 109 110 +1 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/aarch64-be
branch
from
0d8f13f to
40e4cc8
Compare
We have this in cpu/arm.rs to force the build to fail for big-endian ARM/AArch64 targets: ``` const _ASSUMED_ENDIANNESS: () = assert!(cfg!(target_endian = "little")); ``` As a step towards removing that restriction, change the `cfg` logic for ARM and Aarch64 to take the endianness into consideration. Also, don't try to assembly any assembly language sources if the target isn't little endian.
briansmith
force-pushed
the
b/aarch64-be
branch
from
40e4cc8 to
ed4f33e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have this in cpu/arm.rs to force the build to fail for big-endian ARM/AArch64 targets:
As a step towards removing that restriction, change the
cfglogic for ARM and Aarch64 to take the endianness into consideration.Also, don't try to assembly any assembly language sources if the target isn't little endian.