limb: Unmerge usize_from_u32 import from "alloc"-guarded use
#2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
compile-without-alloc
branch
from
9b3f0d0 to
941f85e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
=======================================
Coverage 97.04% 97.04%
=======================================
Files 161 161
Lines 20388 20388
Branches 458 458
=======================================
+ Hits 19785 19786 +1
Misses 495 495
+ Partials 108 107 -1 ☔ View full report in Codecov by Sentry. |
|
Please rebase this on the main branch as some build configuration changes were made that will fix the CI failures. |
Since commit e88750b ("Define native word size as `constant_time::Word`.") `usize_from_u32()` is unconditionally used in and via global `const`s but was (likely accidentally by means of `rust-analyzer`) merged into a `use` statement that's guarded by `feature = "alloc"`. When compiling this crate without that feature, which happens with `default-features = false`, this fails to compile due to missing the import. Moving the import to the unguarded `use crate::` group solves this.
MarijnS95
force-pushed
the
compile-without-alloc
branch
from
941f85e to
f763748
Compare
|
@briansmith ✔️ done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit e88750b ("Define native word size as
constant_time::Word.")usize_from_u32()is unconditionally used in and via globalconsts but was (likely accidentally by means ofrust-analyzer) merged into ausestatement that's guarded byfeature = "alloc". When compiling this crate without that feature, which happens withdefault-features = false, this fails to compile due to missing the import.Moving the import to the unguarded
use crate::group solves this.