Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chacha: Use Overlapping in the implementation of the fallback impl. #2211

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

briansmith
Copy link
Owner

Eliminate all of the unsafe in the fallback implementation.

@briansmith briansmith self-assigned this Jan 9, 2025
@briansmith briansmith changed the title chacha: Use Overlapping in the implementation of the fallback impl. chacha: Use Overlapping in the implementation of the fallback impl. Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 79.79798% with 20 lines in your changes missing coverage. Please review.

Project coverage is 97.02%. Comparing base (fa0c22b) to head (c956545).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/aead/overlapping/base.rs 73.17% 11 Missing ⚠️
src/aead/overlapping/array.rs 77.41% 6 Missing and 1 partial ⚠️
src/aead/chacha/fallback.rs 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2211      +/-   ##
==========================================
- Coverage   97.10%   97.02%   -0.08%     
==========================================
  Files         159      160       +1     
  Lines       20326    20391      +65     
  Branches      457      458       +1     
==========================================
+ Hits        19738    19785      +47     
- Misses        482      498      +16     
- Partials      106      108       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith force-pushed the b/chacha-overlapping branch from 55fe909 to 1a96ae1 Compare January 9, 2025 02:27
@briansmith briansmith force-pushed the b/chacha-overlapping branch 2 times, most recently from b112075 to bf9f9e1 Compare January 9, 2025 04:23
Eliminate all of the `unsafe` in the fallback implementation.
@briansmith briansmith force-pushed the b/chacha-overlapping branch from bf9f9e1 to c956545 Compare January 9, 2025 04:25
@briansmith briansmith merged commit d2e401f into main Jan 9, 2025
156 of 158 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant