RSA: Precompute R**3 and store it instead of R**2. #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the checking of the private modulus from the checking of the private exponent so that we can do things in the order recommended in the NIST spec. This also facilitates storing R**3 instead of R**2 in the `RsaKeyPair`. (We need R**2 during `RsaKeyPair` construction, but R**3 afterwards.)
This saves two private-modulus-length multiplications per RSA private key operation at the cost of two private-modulus-length squarings per `RsaKeyPair` construction.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1817 +/- ##
==========================================
- Coverage 96.00% 96.00% -0.01%
==========================================
Files 137 137
Lines 20727 20741 +14
Branches 226 226
==========================================
+ Hits 19899 19912 +13
- Misses 795 796 +1
Partials 33 33 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves two private-modulus-length multiplications per RSA private key operation at the cost of two private-modulus-length squarings per
RsaKeyPairconstruction.See each individual commit message for details.