ec: NFC: Refactor scalar_sum to eliminate LIMBS_add_mod use.
#1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the pattern we typically use where one argument is passed by value. This lets us use `limbs_add_assign_mod`, eliminating the `unsafe` direct use of `LIMBS_add_mod`. This will make future refactoring easier. This also eliminates the need to construct and zeroize a new scalar `r` for the result.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
- Coverage 96.00% 95.99% -0.01%
==========================================
Files 137 137
Lines 20753 20748 -5
Branches 226 226
==========================================
- Hits 19923 19917 -6
Misses 798 798
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the pattern we typically use where one argument is passed by value.
This lets us use
limbs_add_assign_mod, eliminating theunsafedirect use ofLIMBS_add_mod. This will make future refactoring easier.This also eliminates the need to construct and zeroize a new scalar
rfor the result.