RSA: Remove q_mod_n from RsaKeyPair.
#1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the size of RsaKeyPair by about 15%. Importantly, this was the only non-temporary (`'static`) `Elem` other than `One`.
Codecov Report
@@ Coverage Diff @@
## main #1801 +/- ##
==========================================
+ Coverage 96.01% 96.03% +0.01%
==========================================
Files 137 137
Lines 20752 20755 +3
Branches 226 226
==========================================
+ Hits 19925 19932 +7
+ Misses 791 789 -2
+ Partials 36 34 -2
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the size of RsaKeyPair by about 15%.
Importantly, this was the only non-temporary (
'static)Elemother thanOne.