add an opt-in less-safe-getrandom-custom feature #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Cargo feature treats a user-provided `getrandom` implementation as a secure random number generator (`SecureRandom`). The feature only has effect on targets not supported by `getrandom`. I agree to license my contributions to each file under the terms given at the top of each file I changed.
and have it apply only when `target_os = "none"`
japaric
force-pushed
the
less-safe-getrandom-custom
branch
from
604caec to
2756989
Compare
|
thanks for the review. I have addressed your comments in a new commit. let me know if I should squash the commits. |
1 task
|
is there anything else that should be done in this PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1754 +/- ##
==========================================
- Coverage 96.04% 96.04% -0.01%
==========================================
Files 137 137
Lines 20812 20812
Branches 226 226
==========================================
- Hits 19989 19988 -1
Misses 790 790
- Partials 33 34 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Cargo feature treats a user-provided
getrandomimplementation as a secure random number generator (SecureRandom). The feature only has effect on targets not supported bygetrandom.closes #1734