Remove ChunksFixed which contains one line of unsafe code.
#1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshlf PTAL. |
Codecov Report
@@ Coverage Diff @@
## main #1736 +/- ##
==========================================
- Coverage 96.02% 96.00% -0.03%
==========================================
Files 138 137 -1
Lines 20794 20790 -4
Branches 226 226
==========================================
- Hits 19968 19959 -9
- Misses 790 792 +2
- Partials 36 39 +3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4 tasks
joshlf
reviewed
Oct 15, 2023
| for &'a [T; $unchuncked_len] | ||
| { | ||
| #[inline(always)] | ||
| fn chunks_fixed(self) -> &'a [[T; $chunk_len]; $chunked_len] { |
There was a problem hiding this comment.
Since you've been asking about other places zerocopy might help: this method should be able to be replaced by transmute_ref!, at least in contexts where T and Self are concrete types.
joshlf
approved these changes
Oct 15, 2023
Take a step towards removing the `unsafe` in `ChunksFixed`'s implementation.
This is the last step in the removal of `ChunksFixed`, which contains one line of `unsafe` code.
briansmith
force-pushed
the
b/chunksfixed
branch
from
e201e1f to
1d4e416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages.
chunks_fixed.rs didn't have a license header when it should have. That means that the original LoC total is 14 LoC lower than it should have been. Thus this change is +13 -48 -14 (net -49) LoC, which combined with PR #1732's net +58 means that this project cost 11 LoC using the most naive metric of complexity we can get.
Unlike in PR #1732, here we're using potentially-panicking array slicing or equivalent (e.g.
copy_from_slice). So we're trading static guarantee of not panicking for static guarantee of safety. In this code it is obvious that no panic will be occur so it's not a giant deal. We do the same elsewhere, unfortunately.I don't feel super great about that. However, I think it does help us evaluate using zerocopy or other dependencies (ideally an improved standard library and/or language) to eliminate use of potentially-panicking APIs in addition to eliminating use of
unsafeand/or making ourunsafeuse safer.