bigint elem_exp_consttime: Remove gathering during table construction. #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this code was written, it wasn't clear which assembly language functions took a pointer to the entire state vs. just a pointer to the accumulator (etc.). Now upstream clarified things and we can clarify this code.
Codecov Report
@@ Coverage Diff @@
## main #1733 +/- ##
==========================================
+ Coverage 95.93% 95.98% +0.04%
==========================================
Files 138 138
Lines 20610 20611 +1
Branches 221 221
==========================================
+ Hits 19772 19783 +11
+ Misses 800 790 -10
Partials 38 38
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
When `elem_exp_consttime` replaced `BN_mod_exp_mont_consttime` I did not fully understand the way the table was constructed in the original function. Recent BoringSSL changes clarify the table construction. Do it the same way, to restore performance to what it was previously. This addresses the `// TODO: Optimize this to avoid gathering`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each individual commit message.