Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump braces from 3.0.2 to 3.0.3 #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 17, 2024

Bumps braces from 3.0.2 to 3.0.3.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 17, 2024
Copy link

[puLL-Merge] - micromatch/[email protected]

Description

This pull request introduces several changes to the braces repository, primarily focused on ESLint configurations, brace expansion behavior, documentation, licensing, and test enhancements. The main motivation behind this PR includes:

  1. Adjusting lint rules to adopt a more consistent coding style.
  2. Modifying the brace expansion logic to handle larger sets more effectively.
  3. Updating documentation and licensing information.
  4. Improving and expanding test cases to ensure robustness.
Changes

Changes

  1. .eslintrc.json:

    • Updated the ESLint rules to categorize more rules as warnings rather than errors.
    • Changed configuration to use an array format for the "extends" option.
    • Added new ESLint rules such as no-implicit-coercion and strict.
  2. LICENSE:

    • Updated the license year to the present.
  3. README.md and .verb.md:

    • Fixed formatting inconsistencies in lists.
    • Changed default maxLength value in examples from 65,536 to 10,000 for clarity.
    • General grammar and formatting improvements.
  4. bench/index.js:

    • Simplified interpolation syntax.
  5. examples/expand.js and examples/option-transform.js:

    • Removed unnecessary imports and console logs.
  6. index.js and various lib files (compile.js, constants.js, expand.js, parse.js, stringify.js, utils.js):

    • Incorporated coding style improvements such as replacing let with const where variables are not reassigned.
    • Enhanced range handling and error throwing logic.
  7. package.json:

    • Bumped the version to 3.0.3.
    • Updated the dependency fill-range to ^7.1.1.
  8. test:

    • Numerous test scripts were updated or added to cover various edge cases and coding scenarios.
    • Added tests to validate zero-padded numeric sequences and their increments.
    • Introduced new test script readme.js for validating examples from the README.

Possible Issues

None identified. The changes are primarily focused on code style, documentation, and tests, which should maintain or improve the current codebase without breaking existing functionality.

Security Hotspots

None identified. The PR does not introduce new dependencies or modify critical security-related logic in the existing codebase.

Changes

Changes

  • .eslintrc.json:

    +  "root": true,
    +  "extends": "eslint:recommended",
    -  "extends": [
    -    "eslint:recommended"
    -  ],
    -    "node": true,
    -    "mocha": true
    +    "mocha": true,
    +    "node": true
      "rules": {
    +  "array-bracket-newline": [1, "consistent"],
    +  "array-bracket-spacing": [1, "never"],
    ...
  • LICENSE:

    -Copyright (c) 2014-2018, Jon Schlinkert.
    +Copyright (c) 2014-present, Jon Schlinkert.
  • README.md and .verb.md:

    -**Default**: `65,536`
    +**Default**: `10,000`
    ...
    +- **Accurate** - complete support for the [Bash 4.3 Brace Expansion](www.gnu.org/software/bash/) specification (passes all of the Bash braces tests)
  • bench/index.js:

    -  process.stdout.write(`\u001b[G  ${e.target}${newline ? `\n` : ''}`);
    +  process.stdout.write(`\u001b[G  ${e.target}${newline ? '\n' : ''}`);
  • examples/expand.js:

    -const parse = require('./parse');
  • examples/option-transform.js:

    -  transform(value, index) {
    +  transform(value) {
  • index.js:

    -    for (let pattern of input) {
    +    for (const pattern of input) {
  • lib/ files:

    -      let args = utils.reduce(node.nodes);
    -      let range = fill(...args, { ...options, wrap: false, toRegex: true });
    +      const args = utils.reduce(node.nodes);
    +      const range = fill(...args, { ...options, wrap: false, toRegex: true, strictZeros: true });
  • test/ files:

    +      let options = { ...arr[1] };
    +      let pattern = arr[0];
    +      let expected = arr[2];

Overall, this PR improves code quality, documentation clarity, and test coverage without adverse effects on functionality. Please review the detailed changes for more granular context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants