This repository has been archived by the owner on May 10, 2024. It is now read-only.
Add Brave Player button to navigation bar #8327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return | ||
| } | ||
|
|
||
| if ShieldPreferences.hasSeenAntiAdBlockWarning.value, let etldP1 = url.baseDomain, let components = URLComponents(url: url, resolvingAgainstBaseURL: false) { |
There was a problem hiding this comment.
So is it correct user can only see Brave Player if user pressed "Adjust Shields For Me" button on youtube pop-over ?
There was a problem hiding this comment.
no, the user always sees brave player icon. The adjust shields is just informing the user they should disable shields for YouTube
|
doesn't this require a security review? @stoletheminerals |
cuba
force-pushed
the
js/youtube-warning
branch
from
d2e538b to
b4a7f85
Compare
cuba
force-pushed
the
js/youtube-warning
branch
from
b4a7f85 to
eb111c4
Compare
|
reminder again that the youtube player work on iOS still needs a security review. |
|
All combined here: #8416 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #8326
Submitter Checklist:
NSLocalizableString()Test Plan:
See issue for STR
Screenshots:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-26.at.21.08.23.mp4
Reviewer Checklist:
QA/(Yes|No)bug/enhancement