Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Uplift of #8100: Use proper ad-block components (uplift to 1.60.x) #8321

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Oct 26, 2023

Uplift of #8276
This pull request fixes #8100

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

See issue for STR

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba requested a review from a team as a code owner October 26, 2023 17:13
@cuba cuba changed the base branch from development to bump/1.60.104 October 26, 2023 17:14
@iccub iccub merged commit 3676e8b into bump/1.60.104 Oct 26, 2023
8 checks passed
@iccub iccub deleted the js/1.61-use-proper-ad-block-components branch October 26, 2023 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use proper components for ad-block (reflecting brave-core changes)
2 participants