Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add constellation support for NTT p3a metrics #26863

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

kylehickinson
Copy link
Collaborator

Resolves brave/brave-browser#42108

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See #20264

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Dec 4, 2024
@kylehickinson kylehickinson self-assigned this Dec 4, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner December 4, 2024 16:26

for storage in [jsonStorage, constellationStorage] {
if let eventCounts = storage.eventCounts[creativeInstanceId],
eventCounts.counts.keys.contains(where: { $0 == eventType })
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DJAndries we don't need to check in-flight events right? Based on

void NTPP3AHelperImpl::RemoveMetricIfInstanceDoesNotExist(
I assume not

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's correct

@kylehickinson kylehickinson force-pushed the ios-p3a-constellation-ntt branch 2 times, most recently from 5e1d696 to a7ccf76 Compare December 4, 2024 17:45
@kylehickinson kylehickinson force-pushed the ios-p3a-constellation-ntt branch from a7ccf76 to d035be6 Compare December 9, 2024 16:32
Copy link
Collaborator

@DJAndries DJAndries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kylehickinson kylehickinson merged commit befb8d7 into master Dec 10, 2024
18 checks passed
@kylehickinson kylehickinson deleted the ios-p3a-constellation-ntt branch December 10, 2024 14:20
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 10, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep separate NTT P3A events for Constellation metrics
4 participants