Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Web Discovery reporting & double fetching #24971

Open
wants to merge 7 commits into
base: wdp-native-extraction-payload-gen
Choose a base branch
from
Open

Add Web Discovery reporting & double fetching #24971

wants to merge 7 commits into from
+2,228 −0

Conversation

DJAndries
Copy link
Collaborator

Resolves brave/brave-browser#39439

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@DJAndries DJAndries requested a review from bridiver August 1, 2024 23:09
@DJAndries DJAndries mentioned this pull request Aug 1, 2024
Closed
24 tasks
@DJAndries DJAndries force-pushed the wdp-native-extraction-payload-gen branch from 4b7529f to 4213a66 Compare August 23, 2024 22:26
@DJAndries DJAndries requested review from deeppandya, fmarier and a team August 23, 2024 22:26
fmarier
fmarier approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script/brave_license_helper.py change 👍

@DJAndries DJAndries force-pushed the wdp-native-reporting branch from 37e3465 to 113579d Compare August 23, 2024 23:08
@DJAndries DJAndries force-pushed the wdp-native-extraction-payload-gen branch from 4213a66 to 07bdd3d Compare August 23, 2024 23:40
@DJAndries DJAndries force-pushed the wdp-native-reporting branch from 113579d to 20fe6f6 Compare August 23, 2024 23:41
@DJAndries DJAndries force-pushed the wdp-native-extraction-payload-gen branch from 07bdd3d to 3e0c02c Compare September 17, 2024 04:24
@DJAndries DJAndries requested a review from a team as a code owner September 17, 2024 04:24
@DJAndries DJAndries force-pushed the wdp-native-reporting branch from 2d1b41b to 3e62811 Compare October 25, 2024 01:51
@DJAndries DJAndries requested review from bsclifton, a team, goodov and iefremov as code owners October 25, 2024 01:51
@DJAndries DJAndries force-pushed the wdp-native-reporting branch from 622a60e to ddf7536 Compare November 29, 2024 00:33
@DJAndries DJAndries force-pushed the wdp-native-extraction-payload-gen branch from aac024f to bf1e8a0 Compare January 3, 2025 06:00
@DJAndries DJAndries force-pushed the wdp-native-reporting branch from ddf7536 to 11e37e5 Compare January 3, 2025 06:00
@DJAndries DJAndries force-pushed the wdp-native-extraction-payload-gen branch from bf1e8a0 to 3920d32 Compare January 7, 2025 02:33
@DJAndries DJAndries force-pushed the wdp-native-reporting branch from 11e37e5 to dad9c13 Compare January 7, 2025 02:33
@DJAndries DJAndries force-pushed the wdp-native-extraction-payload-gen branch from 3920d32 to c9d4f04 Compare January 7, 2025 23:25
@DJAndries DJAndries force-pushed the wdp-native-reporting branch from dad9c13 to 95f1036 Compare January 7, 2025 23:25
@DJAndries DJAndries force-pushed the wdp-native-extraction-payload-gen branch from c9d4f04 to b1075d3 Compare January 8, 2025 01:58
@DJAndries DJAndries force-pushed the wdp-native-reporting branch from 95f1036 to 3824bdf Compare January 8, 2025 02:00
@DJAndries DJAndries force-pushed the wdp-native-extraction-payload-gen branch from b1075d3 to 1171918 Compare January 9, 2025 02:00
@DJAndries DJAndries force-pushed the wdp-native-reporting branch from 3824bdf to 71dffba Compare January 9, 2025 02:00
@DJAndries DJAndries force-pushed the wdp-native-extraction-payload-gen branch 2 times, most recently from 77f1ed6 to c7089e1 Compare January 10, 2025 22:52
@DJAndries DJAndries force-pushed the wdp-native-reporting branch from 71dffba to e003a52 Compare January 10, 2025 22:55
@DJAndries DJAndries force-pushed the wdp-native-extraction-payload-gen branch from c7089e1 to 03e489d Compare January 11, 2025 00:15
@DJAndries DJAndries force-pushed the wdp-native-reporting branch 2 times, most recently from 28c2fec to 3a6eb51 Compare January 15, 2025 00:14
iefremov
iefremov reviewed Jan 16, 2025
View reviewed changes
components/web_discovery/browser/web_discovery_service.cc
if (!prev_scrape_result) {
return;
}
content_scraper_->ParseAndScrapePage(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function looks pretty heavy, why don't we do it on the task runner?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do, inside the method itself

@DJAndries DJAndries force-pushed the wdp-native-reporting branch from ff28f48 to 0e33085 Compare January 16, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdesouza-chromium cdesouza-chromium cdesouza-chromium left review comments

@iefremov iefremov iefremov left review comments

@fmarier fmarier fmarier approved these changes

@bridiver bridiver Awaiting requested review from bridiver

@deeppandya deeppandya Awaiting requested review from deeppandya

@bsclifton bsclifton Awaiting requested review from bsclifton

@goodov goodov Awaiting requested review from goodov

@simonhong simonhong Awaiting requested review from simonhong

Assignees

@DJAndries DJAndries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DJAndries @fmarier @iefremov @cdesouza-chromium