Skip to content

Commit

Permalink
[cr133][ios] GoogleGroupsManagerFactory base class changed
Browse files Browse the repository at this point in the history
This has to match the upstream class, as brave is disabling this.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/90765126c2776899a7adc15b4bf9e8a7e5216787

commit 90765126c2776899a7adc15b4bf9e8a7e5216787
Author: Federica Germinario <[email protected]>
Date:   Fri Dec 6 16:37:27 2024 +0000

    Use ProfileKeyedServiceFactoryIOS in GoogleGroupsManagerFactory

    Convert GoogleGroupsManagerFactory to use ProfileKeyedServiceFactoryIOS.
    This improvement removes boilerplate code from the factory.

    Fixed: 363215069
  • Loading branch information
cdesouza-chromium committed Dec 9, 2024
1 parent 54323c9 commit a101cdf
Showing 1 changed file with 3 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,15 @@
}

GoogleGroupsManagerFactory::GoogleGroupsManagerFactory()
: BrowserStateKeyedServiceFactory(
"GoogleGroupsManager",
BrowserStateDependencyManager::GetInstance()) {}
: ProfileKeyedServiceFactoryIOS("GoogleGroupsManager",
ServiceCreation::kCreateWithProfile,
TestingCreation::kNoServiceForTests) {}

std::unique_ptr<KeyedService>
GoogleGroupsManagerFactory::BuildServiceInstanceFor(
web::BrowserState* context) const {
return nullptr;
}

bool GoogleGroupsManagerFactory::ServiceIsCreatedWithBrowserState()
const {
return true;
}

bool GoogleGroupsManagerFactory::ServiceIsNULLWhileTesting() const {
return true;
}

void GoogleGroupsManagerFactory::RegisterBrowserStatePrefs(
user_prefs::PrefRegistrySyncable* registry) {}

0 comments on commit a101cdf

Please sign in to comment.