Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse -codecs output from 1.x-4.x builds of FFmpeg #195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

svjson
Copy link

@svjson svjson commented Mar 4, 2019

The output format of the flags column of codecs have changed starting with FFMpeg 1.0, and so ffmpeg.codecs() returns an empty list.

This pull request uses a different regex pattern for parsing the -codecs output of ffmpeg depending on -version.

@bramp
Copy link
Owner

bramp commented Oct 26, 2023

Sorry for the long delay. This change looks great, thanks for writing it, and sorry I never reviewed it. It looks like I accepted 9a5507c which just fixed it by moving to the latest format. But this pull request looks better by trying the old and new.

If you are willing I'll accept this if you can resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants