Shopper insights rp2 feature #1256
Open
+537
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hts (#1228) * Add methods to ShopperInsightsClient * update unit tests * Add CHANGELOG * Fix typo
* Add shopper insights session ID to paypalRequest * Update factory for paypal request * remove extra setting of email address * Remove optional null and check for null in PayPalRequestFactory * Use String type and fix check for null to prevent run time crashes * Remove DEMO UI updates * Update comment for shopperSessionId * Add experimentalAPI for shopper session Id * Remove unused shopperInsightsSessionIdNullSwitch * Check for null and empty string * Update to use putOpt method for shopperId * Update changelog * Check for null and empty strings for request properties. * Update unit tests * Update test * Update unit tests * Update changelog
* setSessionId from paypalClient * Move analytics instance out of constructor * Update PayPalClient tests to take in a mock analyticsParamRepo * Add unit tests
* Add new shopper session ID analytics param * Fix unit tests * Fix missing analytics * fix lint * Fix lint and add unit tests * update doc string * fix lint
* Add new classes and enums * Update new objects, introduce new method * Use a data class instead * Use the built in functionality to convert the treatment to a string * Update content, update analyticsEventParam to take in a buttonType * Use refactored sendPresentedEvent fun * Remove comments * Update sendPresentedEvent signature * Remove unused methods * Update comments button order * Update comments for button type * Update comments * Update signature * Resolve conflicts * Update PresentmentDetails signature * Update analyticsEvent and add button selected string name * Add comment for shopperSessionId * Update AnalyticsClient * Update unit test * Update presentment signature * Add changelog * Remove shopperSessionId from signature * Remove comment * Remove extra line * Fix lint issues * Newline * Update unit test to test venmo and control type button * Lint issues * Update ButtonOrder * Update keys * PR Comments * Analytics update * Add accessors to enum func to get internal string value * Use upper case notation for enums with a string representation for the page type * Updates * Fix unit test
* fun sendSelectedEvent * Remove PresentmentDetails from selected analytics * Update comment
# Conflicts: # CHANGELOG.md
…-feature # Conflicts: # CHANGELOG.md # PayPal/src/test/java/com/braintreepayments/api/paypal/PayPalClientUnitTest.java
sarahkoop
reviewed
Jan 15, 2025
CHANGELOG.md
Outdated
Comment on lines
4
to
6
|
|
||
| * PayPal | ||
| * Fix bug to ensure that `PayPalVaultRequest.userAuthenticationEmail` is not sent as an empty string |
sarahkoop
reviewed
Jan 15, 2025
CHANGELOG.md
Outdated
Comment on lines
5
to
8
| * ShopperInsights (BETA) | ||
| * Add `isPayPalAppInstalled` and `isVenmoAppInstalled` methods | ||
| * Add `shopperSessionId` parameter to `ShopperInsightsClient` | ||
| * BraintreePayPal | ||
| * Add `shopperSessionId` to `PayPalCheckoutRequest` and `PayPalVaultRequest` | ||
| * Fix bug to ensure that `PayPalVaultRequest.userAuthenticationEmail` is not sent as an empty string | ||
| * Replace `sendPayPalPresentedEvent()` and `sendVenmoPresentedEvent()` with `sendPresentedEvent()` | ||
| * Replace `sendPayPalSelectedEvent()` and `sendVenmoSelectedEvent()` with `sendSelectedEvent()` | ||
| * ThreeDSecure | ||
| * Return error if no `dfReferenceId` is returned in the 3D Secure flow |
There was a problem hiding this comment.
Nit pick - I think the indentation is correct on the original 3DS entry and the new entries are indented too far
sarahkoop
reviewed
Jan 15, 2025
Comment on lines
7
to
8
| * @property buttonOrder optional Represents this buttons order in context of other buttons. | ||
| * @property pageType optional Represents the page or view the button is rendered on. |
There was a problem hiding this comment.
Suggested change
| * @property buttonOrder optional Represents this buttons order in context of other buttons. | |
| * @property pageType optional Represents the page or view the button is rendered on. | |
| * @property buttonOrder Represents this buttons order in context of other buttons. | |
| * @property pageType Represents the page or view the button is rendered on. |
These are not optional based on the code - should they be?
|
Can we do PR step "Tested and confirmed payment flows affected by this change are functioning as expected" to make sure everything is working as expected before merging? |
scannillo
reviewed
Jan 15, 2025
| paymentMethodsDisplayed = paymentMethodsDisplayed | ||
| ) | ||
| ) | ||
| fun isPayPalAppInstalled(context: Context): Boolean { |
There was a problem hiding this comment.
Quick ? - should these methods be marked beta too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Merge ShopperInsights Feature RP2 to main. Updated from main -> rp1 -> rp2.
Checklist
Authors
@jwarmkessel
@warmkesselj