Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT REVIEW] Merge Shipping Callback Feature Branch #1252

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[DO NOT REVIEW] Merge Shipping Callback Feature Branch #1252

wants to merge 5 commits into from

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • These changes were reviewed and approved previously, this is just to trigger CI and ensure all passes before merging into main

Checklist

  • Added a changelog entry
  • Relevant test coverage
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

@richherrera @jaxdesmarais

richherrera and others added 4 commits October 11, 2024 11:01
@richherrera
Add Shipping Callback URL to PayPalRequest (#1185)
506daa9 
* Add shipping callback uri

* Override checkout shipping callback property

* Override vault shipping callback property

* Use let to assign shipping callback value

* Add CheckoutRequest tests

* Add VaultRequest tests

* Update CHANGELOG
@richherrera
Merge branch 'main' into shipping-callback-feature
4188670
@richherrera
Move Shipping Callback URL to PayPalCheckoutRequest (#1200)
182f599 
* Remove unnecessary Vault UTs

* Update CHANGELOG

* Remove shippingCallbackUrl from PayPalRequest interface

* Remove shippingCallbackUri from PayPalVaultRequest class

* Remove unnecessary docstring from interface

* Make shippingCallbackUrl a property of PayPalCheckoutRequest
@jaxdesmarais
Merge branch 'main' into shipping-callback-feature
8849562 
# Conflicts:
#	CHANGELOG.md
@jaxdesmarais jaxdesmarais requested a review from a team as a code owner January 10, 2025 14:38
jaxdesmarais
jaxdesmarais commented Jan 10, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saperi22 saperi22 saperi22 approved these changes

@sarahkoop sarahkoop sarahkoop approved these changes

Assignees
No one assigned
Labels
DO NOT MERGE DO NOT REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaxdesmarais @sarahkoop @saperi22 @richherrera