Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit gracefully if conf.intf.ifname does not exist #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sudipm-mukherjee
Copy link

@sudipm-mukherjee sudipm-mukherjee commented Dec 31, 2023

horst will only work if there is a wlan interface. But if any user tries horst on a system where there is no wifi hardware then it results in a segfault.
As an added benifit this will also protect the user against any misconfiguration of the wlan interface name.

Depends on: br101/libuwifi#9

Copy link
Owner

@br101 br101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

check_if_exists() should be a function in libuwifi/netdev.c and be called something like
netdev_check_if_exists() or similiar.

Otherwise fine. Thank you

horst will only work if there is a wlan interface. But if any user
tries horst on a system where there is no wifi hardware then it results
in a segfault.
As an added benifit this will also protect the user against any
misconfiguration of the wlan interface name.

The segfault has been reported in Ubuntu.

Signed-off-by: Sudip Mukherjee <[email protected]>
@sudipm-mukherjee
Copy link
Author

Thank you for your contribution.

check_if_exists() should be a function in libuwifi/netdev.c and be called something like netdev_check_if_exists() or similiar.

Otherwise fine. Thank you

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants