Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov run to CI #581

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Add codecov run to CI #581

merged 6 commits into from
Jan 5, 2024

Conversation

mborland
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 23, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@mborland
Copy link
Member Author

mborland commented Jan 4, 2024

@ckormanyos Anything you would add or remove from this?

@ckormanyos
Copy link
Member

ckormanyos commented Jan 4, 2024

Anything you would add or remove from this?

Hi Matt (@mborland) I think this is great, both here as well as in math. And it is really cool to see those coverage numbers above $90\%%$.

You will chuckle, but I'd kind of like to show the coverage with our codecov-badge. I know some folks do not really like third party badges so much. But I think they add value as we strive toward the upper nineties, ... unless there is some poicy against them?

Thanks for digging into this Matt´!

@ckormanyos
Copy link
Member

ckormanyos commented Jan 4, 2024

This is the badge we got so far. It is great to be above $90\%$!...

codecov

@ckormanyos
Copy link
Member

ckormanyos commented Jan 4, 2024

If you do decide to show the badges, then where? I don't really know. Maybe a third row in the table on the front page Markdown? But we won't have any data from master for a while...

@mborland
Copy link
Member Author

mborland commented Jan 5, 2024

If you do decide to show the badges, then where? I don't really know. Maybe a third row in the table on the front page Markdown? But we won't have any data from master for a while...

I think a third row on the table is the way to go. I'll hold off adding the badges until we have data from master.

@mborland mborland merged commit ae5bd44 into develop Jan 5, 2024
71 checks passed
@mborland mborland deleted the codecov branch January 5, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants