Merge for 1.84 #1042
Merged
Merge for 1.84 #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `guess` passed to `inverse_discrete_quantile` cannot be represented as floating point number, it is possible that `guess + 1` or `guess - 1` does not change the value at all and we are stuck in infinite loop inside `round_to_floor` or `round_to_ceil`. Fix this by increase/decrease more than 1 in these cases. Example code to reproduce this: ```c++ boost::math::binomial_distribution<> dist(9079765771874083840, 0.561815); boost::math::quantile(dist, 0.0365346); ```
fix unused abterm1 compile warnings
Fix #1016 MSVC 14_0 stdandards and has-include
Fix #1018 via eliminate unused parameter
If `guess` passed to `inverse_discrete_quantile` cannot be represented as floating point number, it is possible that `guess + 1` or `guess - 1` does not change the value at all and we are stuck in infinite loop inside `round_to_floor` or `round_to_ceil`. Fix this by increase/decrease more than 1 in these cases. Example code to reproduce this: ```c++ boost::math::binomial_distribution<> dist(9079765771874083840, 0.561815); boost::math::quantile(dist, 0.0365346); ```
…the non Lanczos case). Completes work started here: #1007
Fixes Conflicts: test/test_binomial.cpp
(Sterling version)
Improve ibeta power term calculation in the Sterling case
Avoid spurious overflow and divide by zero in ibeta.
…rge z. Avoids hitting tgamma on a negative integer, also improves accuracy when b-a-0.5 is close to a negative integer. Fixes #1034.
Adjust recursion when using the Bessel function approximation with la…
Fixes #1035. See also scipy/scipy#19348. Accuracy in left tail is still poor, and the reflection formula appears to be to blame as it's use causes the series to cancel out the first term, but it appears we have no real choice in the matter here. At least we do now get a few digits correct.
Correct non-central-t series convergence bug.
Its int counterpart is a constexpr, and the ten variable never changes, so for consistency, we should make float_type ten constexpr as welll.
ten should be a constexpr as a float
Add tests and make sure everything is covered, and fix resulting errors.
Incorporate cast simplifications from PR880
* initial commit * remove == std::denorm_present * remove extra ) in ccmath/next
This fixes ambiguous overloads in the multiprecision case between boost::multiprecision and boost::math versions of log1p. See boostorg/multiprecision#568 (comment)
Qualify log1p calls.
|
I believe this has to wait for: boostorg/multiprecision#570 since there were cross library fixes. |
Fix detection of ccmath usage in trunc
Update/improve ccmath configuration.
|
One failure is a clone/network error, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.