Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mostly remove pre-CXX11 workarounds. #82

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Mostly remove pre-CXX11 workarounds. #82

wants to merge 14 commits into from

Conversation

gogagum
Copy link

@gogagum gogagum commented Jun 10, 2024 •
edited
Loading

С++03 support was deprecated in 1.85 and now can be removed. This PR clears many of workarounds, which are no longer needed now.

  • Remove unused workaround macros (many of).
  • Remove BOOST_STATIC_ASSERT usages.
  • Minimize Boost::type_traits dependency (in favour of STL's type_traits).

Lastique
Lastique reviewed Jun 10, 2024
View reviewed changes
include/boost/iterator/counting_iterator.hpp Outdated Show resolved Hide resolved
include/boost/iterator/filter_iterator.hpp Outdated Show resolved Hide resolved
include/boost/iterator/function_input_iterator.hpp Show resolved Hide resolved
include/boost/iterator/is_iterator.hpp Outdated Show resolved Hide resolved
include/boost/iterator/iterator_adaptor.hpp Show resolved Hide resolved
include/boost/iterator/iterator_adaptor.hpp Outdated Show resolved Hide resolved
test/detail/zip_iterator_test.ipp Outdated Show resolved Hide resolved
test/is_iterator.cpp Outdated Show resolved Hide resolved
test/range_distance_compat_test.cpp Outdated Show resolved Hide resolved
@gogagum gogagum force-pushed the develop branch 4 times, most recently from 65f155a to 9e5a65f Compare June 12, 2024 15:24
@Lastique
Copy link
Member

Also, as a general comment, please convert this to a draft PR until you consider everything done and ready for review.

@gogagum gogagum marked this pull request as draft June 24, 2024 08:03
@gogagum gogagum force-pushed the develop branch 3 times, most recently from fa28bec to e49506b Compare October 10, 2024 22:46
@gogagum gogagum marked this pull request as ready for review October 10, 2024 22:58
Lastique
Lastique reviewed Oct 11, 2024
View reviewed changes
include/boost/iterator/interoperable.hpp Outdated Show resolved Hide resolved
include/boost/iterator/counting_iterator.hpp Outdated Show resolved Hide resolved
include/boost/iterator/detail/facade_iterator_category.hpp Outdated Show resolved Hide resolved
include/boost/iterator/detail/type_traits/conjunction.hpp Outdated Show resolved Hide resolved
include/boost/iterator/is_iterator.hpp Outdated Show resolved Hide resolved
include/boost/pending/iterator_tests.hpp Outdated Show resolved Hide resolved
test/indirect_iter_member_types.cpp Outdated Show resolved Hide resolved
test/iterator_adaptor_test.cpp Outdated Show resolved Hide resolved
test/iterator_adaptor_test.cpp Outdated Show resolved Hide resolved
test/permutation_iterator_test.cpp Show resolved Hide resolved
@Lastique Lastique marked this pull request as draft October 11, 2024 16:03
@gogagum gogagum marked this pull request as ready for review December 21, 2024 23:33
@gogagum gogagum requested a review from Lastique January 18, 2025 11:36
Lastique
Lastique requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@Lastique Lastique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you're almost there. Only a few minor comments left.

include/boost/iterator/function_input_iterator.hpp Outdated Show resolved Hide resolved
include/boost/iterator/iterator_facade.hpp Outdated Show resolved Hide resolved
include/boost/iterator/new_iterator_tests.hpp Outdated Show resolved Hide resolved
include/boost/iterator/new_iterator_tests.hpp Outdated Show resolved Hide resolved
include/boost/iterator/new_iterator_tests.hpp Outdated Show resolved Hide resolved
include/boost/iterator/new_iterator_tests.hpp Outdated Show resolved Hide resolved
test/static_assert_same.hpp Outdated Show resolved Hide resolved
@gogagum
Correct static_assert messages.
39815e4
@gogagum
Remove BOOST_NO_STRICT_ITERATOR_INTEROPERABILITY
367f73c 
Correct static_assert messages.
Fix messages & replace is_standard_layout with is_copy_constructible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lastique Lastique Lastique requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gogagum @Lastique