Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement WebSocket-based Playwright tests #204

Merged
merged 12 commits into from
Dec 5, 2024
Merged

feat: Implement WebSocket-based Playwright tests #204

merged 12 commits into from
Dec 5, 2024

Conversation

kwaksj329
Copy link
Member

πŸ“‚ μž‘μ—… λ‚΄μš©

closes #202

  • μ›Ήμ†ŒμΌ“ 톡신 기반 μΊ”λ²„μŠ€ 동기화 μΈ‘μ •μš© Playwright ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±

πŸ’‘ μžμ„Έν•œ μ„€λͺ…

(κ°€λŠ₯ν•œ ν•œ μžμ„Ένžˆ μž‘μ„±ν•΄ μ£Όμ‹œλ©΄ 도움이 λ©λ‹ˆλ‹€.)

πŸ“— μ°Έκ³  자료 & κ΅¬ν˜„ κ²°κ³Ό (선택)

πŸ“’ 리뷰 μš”κ΅¬ 사항 (선택)

🚩 후속 μž‘μ—… (선택)

βœ… μ…€ν”„ 체크리슀트

  • PR 제λͺ©μ„ ν˜•μ‹μ— 맞게 μž‘μ„±ν–ˆλ‚˜μš”?
  • 브랜치 μ „λž΅μ— λ§žλŠ” λΈŒλžœμΉ˜μ— PR을 올리고 μžˆλ‚˜μš”? (main이 μ•„λ‹™λ‹ˆλ‹€.)
  • μ΄μŠˆλŠ” close ν–ˆλ‚˜μš”?
  • Reviewers, Labelsλ₯Ό λ“±λ‘ν–ˆλ‚˜μš”?
  • μž‘μ—… 도쀑 λ¬Έμ„œ μˆ˜μ •μ΄ ν•„μš”ν•œ 경우 잘 μˆ˜μ •ν–ˆλ‚˜μš”?
  • ν…ŒμŠ€νŠΈλŠ” 잘 ν†΅κ³Όν–ˆλ‚˜μš”?
  • λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?

@kwaksj329 kwaksj329 added βš™ Setting Development Environment Setting βœ… Test Test (storybook, jest...) labels Dec 5, 2024
@kwaksj329 kwaksj329 added this to the Week 6 milestone Dec 5, 2024
@kwaksj329 kwaksj329 self-assigned this Dec 5, 2024
@kwaksj329 kwaksj329 linked an issue Dec 5, 2024 that may be closed by this pull request
μ›Ήμ†ŒμΌ“ ν™˜κ²½μ—μ„œ CRDT Playwright ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„± #202
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

πŸ“š Storybook preview deployed to: Visit Storybook Preview

@kwaksj329 kwaksj329 merged commit d301f1c into develop Dec 5, 2024
2 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

🧹 Storybook preview for PR #204 has been removed.

github-actions bot added a commit that referenced this pull request Dec 5, 2024
@github-actions
docs: remove storybook preview for PR #204
7af0aee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhino-ty rhino-ty rhino-ty approved these changes

@choiseona choiseona choiseona approved these changes

@ssum1ra ssum1ra Awaiting requested review from ssum1ra

@dbjoung dbjoung Awaiting requested review from dbjoung

Assignees

@kwaksj329 kwaksj329

Labels
βš™ Setting Development Environment Setting βœ… Test Test (storybook, jest...)
Projects
None yet
Milestone
Week 6
Development

Successfully merging this pull request may close these issues.

μ›Ήμ†ŒμΌ“ ν™˜κ²½μ—μ„œ CRDT Playwright ν…ŒμŠ€νŠΈ μ½”λ“œ μž‘μ„±
3 participants
@kwaksj329 @choiseona @rhino-ty