Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implements help component and prevents dragging #199

Merged
merged 20 commits into from
Dec 5, 2024
Merged

feat: Implements help component and prevents dragging #199

merged 20 commits into from
Dec 5, 2024

Conversation

dbjoung
Copy link
Collaborator

@dbjoung dbjoung commented Dec 4, 2024 •
edited
Loading

πŸ“‚ μž‘μ—… λ‚΄μš©

closes #189

  • UI 섀계
  • 도움말 κ΅¬ν˜„
  • 이미지&ν…μŠ€νŠΈ λ“œλž˜κ·Έ 방지 (단, Chat Bubble은 λ“œλž˜κ·Έ κ°€λŠ₯ν•˜λ„λ‘ μ„€μ •)

πŸ’‘ μžμ„Έν•œ μ„€λͺ…

  • 우츑 상단 도움말 ν† κΈ€ 클릭 μ‹œ λ‚˜νƒ€λ‚˜λŠ” 도움말 λͺ¨λ‹¬ νŽ˜μ΄μ§€ κ΅¬ν˜„
    • lottieFiles μ• λ‹ˆλ©”μ΄μ…˜ 적용
    • json 파일둜 적용
    • μž¬μƒ 컨트둀 μœ„ν•΄ '@lottiefiles/react-lottie-player' 라이브러리 μΆ”κ°€ μ„€μΉ˜
  • 이미지 & ν…μŠ€νŠΈ λ“œλž˜κ·Έ 방지
    • index.css λ‹¨μ—μ„œ μ„€μ •
    • chat bubble만 λ“œλž˜κ·Έ κ°€λŠ₯ν•˜λ„λ‘ μ„€μ •

πŸ“— μ°Έκ³  자료 & κ΅¬ν˜„ κ²°κ³Ό (선택)

μ‹œμ—° μ˜μƒ

helpcomponent

μ„±λŠ₯ κ΄€λ ¨ 이슈

  • 도움말 νŽ˜μ΄μ§€ 적용 ν›„ 초기 λ‘œλ”© 점수 5점 ν•˜λ½
  • μ• λ‹ˆλ©”μ΄μ…˜ μ†ŒμŠ€λ₯Ό 초기 λ‘œλ”© μ‹œ λͺ¨λ‘ κ°€μ Έμ˜€κΈ° λ•Œλ¬ΈμΈ 것 κ°™μŒ.
  • ν•„μš”ν•œ μ‹œμ μ— μ• λ‹ˆλ©”μ΄μ…˜ κ°€μ Έμ˜€λ„λ‘ μ½”λ“œ μˆ˜μ • ν•„μš”
    μ„±λŠ₯before
    μ„±λŠ₯after

도움말 ν…μŠ€νŠΈ

  1. κ²Œμž„μ„ ν•¨κ»˜ ν•  친ꡬλ₯Ό λͺ¨μœΌμ„Έμš”. 그리고 κ²Œμž„ μ‹œμž‘μ„ λˆ„λ₯΄μ„Έμš”.
  2. 그림꾼은 μ œμ‹œμ–΄λ₯Ό ν‘œν˜„ν•˜μ„Έμš”. 방해꾼은 그림꾼을 λ°©ν•΄ν•˜μ„Έμš”.
  3. ꡬ경꾼은 타이머 μ’…λ£Œ ν›„ μ œμ‹œμ–΄λ₯Ό λ§žμΆ”μ„Έμš”. 정닡이면 맞좘 ꡬ경꾼과 그림꾼이, μ˜€λ‹΅μ΄λ©΄ 방해꾼이 점수λ₯Ό μ–»μ–΄μš”.
  4. μ„€μ •ν•œ λΌμš΄λ“œ 수 만큼 κ²Œμž„μ„ μ¦κΈ°μ„Έμš”. 맀 λΌμš΄λ“œ λ§ˆλ‹€ 역할이 λ°”λ€Œμ–΄μš”.
  5. μ‹œμƒλŒ€μ—μ„œ 승리의 기쁨을 λˆ„λ¦¬μ„Έμš”. 1등이 μ•„λ‹ˆλΌλ©΄ λ‹€μŒ κ²Œμž„μ„ λ…Έλ €λ³΄μ„Έμš”.

πŸ“’ 리뷰 μš”κ΅¬ 사항 (선택)

🚩 후속 μž‘μ—… (선택)

  • light house 수치 기반으둜 μ΅œμ ν™” ν•„μš”

βœ… μ…€ν”„ 체크리슀트

  • PR 제λͺ©μ„ ν˜•μ‹μ— 맞게 μž‘μ„±ν–ˆλ‚˜μš”?
  • 브랜치 μ „λž΅μ— λ§žλŠ” λΈŒλžœμΉ˜μ— PR을 올리고 μžˆλ‚˜μš”? (main이 μ•„λ‹™λ‹ˆλ‹€.)
  • μ΄μŠˆλŠ” close ν–ˆλ‚˜μš”?
  • Reviewers, Labelsλ₯Ό λ“±λ‘ν–ˆλ‚˜μš”?
  • μž‘μ—… 도쀑 λ¬Έμ„œ μˆ˜μ •μ΄ ν•„μš”ν•œ 경우 잘 μˆ˜μ •ν–ˆλ‚˜μš”?
  • ν…ŒμŠ€νŠΈλŠ” 잘 ν†΅κ³Όν–ˆλ‚˜μš”?
  • λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?

@dbjoung dbjoung linked an issue Dec 4, 2024 that may be closed by this pull request
도움말 κ΅¬ν˜„ #189
Closed
3 tasks
@dbjoung dbjoung changed the title Feature/#189 feat: Implements help component and prevents dragging Dec 4, 2024
@dbjoung dbjoung self-assigned this Dec 4, 2024
@dbjoung dbjoung added ✨ Feature New feature or request πŸ’» FE Frontend Code labels Dec 4, 2024
@dbjoung dbjoung added this to the Week 6 milestone Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

πŸ“š Storybook preview deployed to: Visit Storybook Preview

@dbjoung dbjoung requested review from rhino-ty and choiseona December 4, 2024 08:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

πŸ“š Storybook preview deployed to: Visit Storybook Preview

@dbjoung dbjoung requested review from kwaksj329 and ssum1ra December 4, 2024 08:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

πŸ“š Storybook preview deployed to: Visit Storybook Preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

πŸ“š Storybook preview deployed to: Visit Storybook Preview

kwaksj329
kwaksj329 reviewed Dec 4, 2024
View reviewed changes
client/src/components/modal/RollingModal.tsx Outdated
Comment on lines 15 to 18
handle: {
closeModal: () => void;
openModal: () => void;
handleKeyDown: (e: KeyboardEvent<Element>) => void;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

더 ν‰ν‰ν•œ ꡬ쑰둜 props에 μ ‘κ·Όν•  수 μžˆλ„λ‘ handleCloseModal 처럼 μ‚¬μš©ν•˜λŠ” 것은 μ–΄λ–¨κΉŒμš”?
ν˜Ήμ€ handle 객체둜 κ°μ‹ΈλŠ”κ²Œ 더 μ ν•©ν•˜λ‹€κ³  μƒκ°ν•˜μ‹ λ‹€λ©΄ handlerκ°€ μ˜λ―Έμƒ 더 μ μ ˆν•  것 κ°™μŠ΅λ‹ˆλ‹€.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

πŸ“š Storybook preview deployed to: Visit Storybook Preview

@dbjoung dbjoung requested a review from kwaksj329 December 5, 2024 06:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

πŸ“š Storybook preview deployed to: Visit Storybook Preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

πŸ“š Storybook preview deployed to: Visit Storybook Preview

rhino-ty
rhino-ty approved these changes Dec 5, 2024
View reviewed changes
client/src/layouts/RootLayout.tsx Outdated
<img src={helpIcon} alt="도움말 보기 λ²„νŠΌ" />
</Button>
<RollingModal isModalOpened={isModalOpened} handle={{ closeModal, openModal, handleKeyDown }} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttonκ³Ό RollingModal을 λ¬Άμ–΄μ„œ ν•œ μ»΄ν¬λ„ŒνŠΈμ—μ„œ ν•Έλ“€λŸ¬ 및 μ»€μŠ€ν…€ ν›… μ‚¬μš© ν›„ λ ˆμ΄μ•„μ›ƒμ— μ˜¬λ €μ£Όμ„Έμš”~

client/package.json Outdated
@@ -19,6 +19,8 @@
},
"dependencies": {
"@lottiefiles/dotlottie-react": "^0.10.1",
"@lottiefiles/react-lottie-player": "^3.5.4",
"@tanstack/react-query": "^5.59.19",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanstack/react-query μ‚­μ œν•΄μ£Όμ„Έμš”~

@rhino-ty rhino-ty merged commit 8bc1576 into develop Dec 5, 2024
2 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

🧹 Storybook preview for PR #199 has been removed.

github-actions bot added a commit that referenced this pull request Dec 5, 2024
@github-actions
docs: remove storybook preview for PR #199
04acf87
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

πŸ“š Storybook preview deployed to: Visit Storybook Preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhino-ty rhino-ty rhino-ty approved these changes

@choiseona choiseona choiseona approved these changes

@ssum1ra ssum1ra Awaiting requested review from ssum1ra

@kwaksj329 kwaksj329 Awaiting requested review from kwaksj329

Assignees

@dbjoung dbjoung

Labels
πŸ’» FE Frontend Code ✨ Feature New feature or request
Projects
None yet
Milestone
Week 6
Development

Successfully merging this pull request may close these issues.

도움말 κ΅¬ν˜„
4 participants
@dbjoung @choiseona @kwaksj329 @rhino-ty