Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#373 - suspense, error boundary, alarm로직 변경 #375

Merged
merged 21 commits into from
Dec 5, 2024

Conversation

baegyeong
Copy link
Collaborator

close #373

✅ 작업 내용

  • suspense, error boundary 적용
  • lazy 적용
  • useSuspenseQuery, useSuspenseQueries, useSuspenseInfiniteQuery 부분 적용
  • alarm 로직 변경

😎 체크 사항

  • label 설정 확인
  • 브랜치 방향 확인

@baegyeong baegyeong requested a review from a team December 5, 2024 03:00
@baegyeong baegyeong self-assigned this Dec 5, 2024
@baegyeong baegyeong added ✨feature 기능 개발 FE labels Dec 5, 2024
Copy link
Collaborator

@xjfcnfw3 xjfcnfw3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 👍 👍

targetVolume: z.string().nullable(),
alarmDate: z.string().datetime(),
targetVolume: z.number().nullable(),
alarmExpiredDate: z.string().datetime().nullable(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗...

Copy link
Collaborator

@swkim12345 swkim12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@baegyeong baegyeong merged commit 329fc69 into dev-fe Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE ✨feature 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants