Feature/#365 알림 response 변경, 알림 검증 로직 추가, 중복 함수 리팩토링 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
xjfcnfw3
approved these changes
Dec 4, 2024
| @@ -33,14 +33,14 @@ export class AlarmResponse { | |||
| example: 10, | |||
| nullable: true, | |||
| }) | |||
| alarmDate?: Date; | |||
| alarmExpiredDate?: Date; | |||
There was a problem hiding this comment.
로컬상에서는 괜찮았는데... 확인해볼게요!
| ): boolean { | ||
| if ( | ||
| alarm.alarmExpiredDate && | ||
| this.isAlarmNotExpired(alarm.alarmExpiredDate, recent) |
There was a problem hiding this comment.
예외 처리 관련로직을 함수로 분리한거 굿입니다!
baegyeong
approved these changes
Dec 4, 2024
| ): boolean { | ||
| if ( | ||
| alarm.alarmExpiredDate && | ||
| this.isAlarmNotExpired(alarm.alarmExpiredDate, recent) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #365
✅ 작업 내용
alarmExpiredDate로 변경📌 이슈 사항
😎 체크 사항