Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/#345 - 제약조건 에러 해결 및 각종 버그 수정 #363

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

xjfcnfw3
Copy link
Collaborator

@xjfcnfw3 xjfcnfw3 commented Dec 4, 2024

close #345

✅ 작업 내용

  • 새로 상장된 주식에 의한 제약조건 에러 수정
  • 같은 우선순위일 때 stack처럼 동작하는 현상 수정
  • 주말에 차트 데이터를 수집하지 않도록 변경
  • 기타 코드 리펙토링

📌 이슈 사항

  • cron 주기를 장이 정산되는 시점인 받는 화 ~ 토로 설정했습니다.
    • 잘못된 주기가 있으면 알려주세요!

😎 체크 사항

  • label 설정 확인
  • 브랜치 방향 확인

@xjfcnfw3 xjfcnfw3 added 🐞 bugfix Something isn't working ✨feature 기능 개발 BE labels Dec 4, 2024
@xjfcnfw3 xjfcnfw3 requested a review from a team December 4, 2024 12:31
Copy link
Collaborator

@baegyeong baegyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -12,7 +12,7 @@ export class LikeResponse {
@ApiProperty({
type: 'string',
description: '참여 중인 좀목 id',
example: 'A005930',
example: '005930',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이젠 테스트 통과할수도?

@@ -1,12 +1,11 @@
export class PriorityQueue<T> {
private heap: { value: T; priority: number }[];
type HeapNode<T> = { value: T; priority: number; order: number };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타입 빼니깐 보기 좋네요!

Copy link
Collaborator

@swkim12345 swkim12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리팩토링 수고하셨습니다!

@xjfcnfw3 xjfcnfw3 merged commit c035e0e into dev-be Dec 4, 2024
@swkim12345 swkim12345 deleted the bug/#345 branch December 5, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE ✨feature 기능 개발 🐞 bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants