Feature/#332 - 누락된 최신 차트데이터가 존재하면 API 요청 후 차트데이터 전달 #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
이거 혹시 모르니깐 내일 아침에 머지할게요 데이터 서버에서 다 먹음 할게요.. |
swkim12345
reviewed
Dec 3, 2024
| @@ -1,6 +1,6 @@ | |||
| import { Inject, Injectable } from '@nestjs/common'; | |||
| import { Cron } from '@nestjs/schedule'; | |||
| import { DataSource } from 'typeorm'; | |||
| import { DataSource, QueryFailedError } from 'typeorm'; | |||
There was a problem hiding this comment.
오? 아니 왜 이런 걸 쿡북에 안 작성해주는거야
swkim12345
reviewed
Dec 3, 2024
Comment on lines
+57
to
+63
| isSameDate(dateToCompare: NewDate | Date): boolean { | ||
| return ( | ||
| this.getFullYear() === dateToCompare.getFullYear() && | ||
| this.getMonth() === dateToCompare.getMonth() && | ||
| this.getDate() === dateToCompare.getDate() | ||
| ); | ||
| } |
swkim12345
reviewed
Dec 3, 2024
Comment on lines
+60
to
+64
| const queryBuilder = this.createQueryBuilder( | ||
| entity, | ||
| stockId, | ||
| manager, | ||
| lastStartTime, |
There was a problem hiding this comment.
이..이게 뭐고... 상당히 쉽게 할 수 있네요
swkim12345
approved these changes
Dec 3, 2024
baegyeong
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #332
✅ 작업 내용
📌 이슈 사항
😎 체크 사항