Bug/#257 detail 로직 변경 #258
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import { DataSource } from 'typeorm'; | ||
| import { openApiConfig } from '../config/openapi.config'; | ||
| import { Stock } from '@/stock/domain/stock.entity'; | ||
|
|
||
| export abstract class Openapi { | ||
| constructor(protected readonly datasource: DataSource) {} | ||
|
|
||
| protected abstract start(): Promise<void>; | ||
|
|
||
| protected abstract interval(idx: number, stocks: Stock[]): Promise<void>; | ||
|
|
||
| protected abstract step(idx: number, stock: Stock): Promise<void>; | ||
|
|
||
| protected abstract getFromUrl( | ||
| config: typeof openApiConfig, | ||
| stockId: string, | ||
| ): object; | ||
|
|
||
| protected abstract convertResToEntity(res: object, stockId: string): object; | ||
|
|
||
| protected async getStockId() { | ||
| const entity = Stock; | ||
| const manager = this.datasource.manager; | ||
| const result = await manager.find(entity, { | ||
| select: { id: true }, | ||
| where: { isTrading: true }, | ||
| }); | ||
| return result; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,278 +1,112 @@ | ||
| import { Inject, Injectable } from '@nestjs/common'; | ||
| import { Cron } from '@nestjs/schedule'; | ||
| import { DataSource } from 'typeorm'; | ||
| import { Logger } from 'winston'; | ||
| import { openApiConfig } from '../config/openapi.config'; | ||
| import { DetailData, isDetailData } from '../type/openapiDetailData.type'; | ||
| import { TR_ID } from '../type/openapiUtil.type'; | ||
| import { getOpenApi } from '../util/openapiUtil.api'; | ||
| import { Openapi } from './openapi.abstract'; | ||
| import { OpenapiTokenApi } from './openapiToken.api'; | ||
| import { Stock } from '@/stock/domain/stock.entity'; | ||
| import { StockDetail } from '@/stock/domain/stockDetail.entity'; | ||
|
|
||
| @Injectable() | ||
| export class OpenapiDetailData extends Openapi { | ||
| private readonly TR_ID: TR_ID = 'FHKST01010100'; | ||
| private readonly url: string = | ||
| '/uapi/domestic-stock/v1/quotations/inquire-price'; | ||
| constructor( | ||
| @Inject('winston') private readonly logger: Logger, | ||
| protected readonly datasource: DataSource, | ||
| private readonly config: OpenapiTokenApi, | ||
| ) { | ||
| super(datasource); | ||
| } | ||
|
|
||
| @Cron('35 0 * * 1-5') | ||
| async start() { | ||
| const stock = await this.getStockId(); | ||
| const len = (await this.config.configs()).length; | ||
| const stockSize = Math.ceil(stock.length / len); | ||
| let i = 0; | ||
| while (i < len) { | ||
| this.interval(i, stock.slice(i * stockSize, (i + 1) * stockSize)); | ||
| i++; | ||
| } | ||
| } | ||
|
|
||
| protected async interval(idx: number, stocks: Stock[]) { | ||
| const interval = 100; | ||
| let time = 0; | ||
| for (const stock of stocks) { | ||
| setTimeout(() => this.step(idx, stock), time); | ||
| time += interval; | ||
| } | ||
| } | ||
|
|
||
| protected async step(idx: number, stock: Stock) { | ||
| try { | ||
| const config = (await this.config.configs())[idx]; | ||
| const res = await this.getFromUrl(config, stock.id); | ||
| if (res.output && isDetailData(res.output)) { | ||
| const entity = this.convertResToEntity(res.output, stock.id); | ||
| await this.save(entity); | ||
| } | ||
| } catch (error) { | ||
| this.logger.warn(`Error in detail data : ${error}`); | ||
| setTimeout(() => this.step(idx, stock), 100); | ||
| } | ||
| } | ||
|
|
||
| protected async getFromUrl(config: typeof openApiConfig, stockId: string) { | ||
| const query = this.query(stockId); | ||
| const res = await getOpenApi(this.url, config, query, this.TR_ID); | ||
| if (res) return res; | ||
| else throw new Error(); | ||
| } | ||
|
|
||
| protected convertResToEntity(res: DetailData, stockId: string): StockDetail { | ||
| const result = new StockDetail(); | ||
| result.eps = parseInt(res.eps); | ||
| result.high52w = parseInt(res.w52_hgpr); | ||
| result.low52w = parseInt(res.w52_lwpr); | ||
| result.marketCap = res.hts_avls; | ||
| result.per = parseFloat(res.per); | ||
|
Comment on lines
+71
to
+75
There was a problem hiding this comment. 오 parseInt, parseFloat 따로 있군요 프론트측에서도 이렇게 받아야겠네요 |
||
| result.stock = { id: stockId } as Stock; | ||
| result.updatedAt = new Date(); | ||
| return result; | ||
| } | ||
|
|
||
| //private async getStockId() { | ||
| // const entity = Stock; | ||
| // const manager = this.datasource.manager; | ||
| // const result = await manager.find(entity, { | ||
| // select: { id: true }, | ||
| // where: { isTrading: true }, | ||
| // }); | ||
| // return result; | ||
| //} | ||
|
|
||
| private async save(saveEntity: StockDetail) { | ||
| const entity = StockDetail; | ||
| const manager = this.datasource.manager; | ||
| await manager | ||
| .createQueryBuilder() | ||
| .insert() | ||
| .into(entity) | ||
| .values(saveEntity) | ||
| .orUpdate( | ||
| ['market_cap', 'eps', 'per', 'high52w', 'low52w', 'updated_at'], | ||
| ['stock_id'], | ||
| ) | ||
| .execute(); | ||
| } | ||
|
|
||
| protected query(stockId: string, code: 'J' = 'J') { | ||
| return { | ||
| fid_cond_mrkt_div_code: code, | ||
| fid_input_iscd: stockId, | ||
| }; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 이걸 만드신 이유가 궁금합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전반적으로 openapi 내부 클래스들이 너무 중구난방이라 추상클래스로 묶은 다음 관리하려고 그랬습니다! 일단 향후 만들 클래스는 추상클래스를 상속받은 다음 구현할 까 합니다.