Merge pull request #53 from bloxbean/fix_49

feat: #48 Added onParsingError call back to listen to any block parsing error
bloxbean · Feb 26, 2024 · e1852b2 · e1852b2
2 parents 63e7f99 + 06e0983
commit e1852b2
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 3 deletions.
diff --git a/core/src/main/java/com/bloxbean/cardano/yaci/core/protocol/blockfetch/BlockfetchAgent.java b/core/src/main/java/com/bloxbean/cardano/yaci/core/protocol/blockfetch/BlockfetchAgent.java
@@ -137,9 +137,17 @@ private void onReceiveBlocks(MsgBlock message) {
         } catch (Exception e) {
             errorBlks++;
             log.error("Error in parsing", e);
-            Array headerArray = (Array) ((Array)array.getDataItems().get(1)).getDataItems().get(0);
-            BlockHeader blockHeader = BlockHeaderSerializer.INSTANCE.getBlockHeaderFromHeaderArray(headerArray);
-            log.error("BlockHeader >> Block No: " + blockHeader.getHeaderBody().getBlockNumber() +", Slot: " + blockHeader.getHeaderBody().getSlot());
+
+            //Catch exception to avoid exception propagation
+            try {
+                Array headerArray = (Array) ((Array) array.getDataItems().get(1)).getDataItems().get(0);
+                BlockHeader blockHeader = BlockHeaderSerializer.INSTANCE.getBlockHeaderFromHeaderArray(headerArray);
+                log.error("BlockHeader >> Block No: " + blockHeader.getHeaderBody().getBlockNumber() + ", Slot: " + blockHeader.getHeaderBody().getSlot());
+            } catch (Exception e1) {
+                log.error("Error in parsing block header", e1);
+            }
+
+            getAgentListeners().stream().forEach(blockfetchAgentListener -> blockfetchAgentListener.onParsingError(e));
         }
     }
 

diff --git a/...main/java/com/bloxbean/cardano/yaci/core/protocol/blockfetch/BlockfetchAgentListener.java b/...main/java/com/bloxbean/cardano/yaci/core/protocol/blockfetch/BlockfetchAgentListener.java
@@ -35,4 +35,8 @@ default void byronEbBlockFound(ByronEbBlock byronEbBlock) {
 
     }
 
+    default void onParsingError(Exception e) {
+
+    }
+
 }
diff --git a/helper/src/main/java/com/bloxbean/cardano/yaci/helper/listener/BlockChainDataListener.java b/helper/src/main/java/com/bloxbean/cardano/yaci/helper/listener/BlockChainDataListener.java
@@ -42,4 +42,6 @@ default void intersactFound(Tip tip, Point point) {}
     default void intersactNotFound(Tip tip) {}
 
     default void onDisconnect() {}
+
+    default void onParsingError(Exception e) {}
 }
diff --git a/...c/main/java/com/bloxbean/cardano/yaci/helper/listener/BlockFetchAgentListenerAdapter.java b/...c/main/java/com/bloxbean/cardano/yaci/helper/listener/BlockFetchAgentListenerAdapter.java
@@ -131,4 +131,9 @@ public void noBlockFound(Point from, Point to) {
     public void onDisconnect() {
         blockChainDataListener.onDisconnect();
     }
+
+    @Override
+    public void onParsingError(Exception e) {
+        blockChainDataListener.onParsingError(e);
+    }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -35,4 +35,8 @@ default void byronEbBlockFound(ByronEbBlock byronEbBlock) { @@
         }
+        default void onParsingError(Exception e) {
+        }
     }