Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform TO run_inference_loop #621

Merged
merged 3 commits into from
Dec 10, 2023

Conversation

reubenharry
Copy link
Contributor

@reubenharry reubenharry commented Dec 9, 2023

A first step towards issue #615.

A simple change, in case a user doesn't want to store all the history of the state in a large high dimensional run, for reasons of memory.

A few important guidelines and requirements before we can merge your PR:

  • If I add a new sampler, there is an issue discussing it already;
  • We should be able to understand what the PR does from its title only;
  • There is a high-level description of the changes;
  • There are links to all the relevant issues, discussions and PRs;
  • The branch is rebased on the latest main commit;
  • Commit messages follow these guidelines;
  • The code respects the current naming conventions;
  • Docstrings follow the numpy style guide
  • pre-commit is installed and configured on your machine, and you ran it before opening the PR;

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08e0d75) 99.22% compared to head (375ec14) 99.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          57       57           
  Lines        2581     2581           
=======================================
  Hits         2561     2561           
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@junpenglao
Copy link
Member

Thanks!
Please add a docstring (And while you are at it, could you update the docstring as well?)

@junpenglao junpenglao changed the title ADD TRANSFORM TO run_inference_loop Add transform TO run_inference_loop Dec 10, 2023
@junpenglao junpenglao merged commit 4ae2faf into blackjax-devs:main Dec 10, 2023
7 checks passed
junpenglao pushed a commit that referenced this pull request Mar 12, 2024
* ADD TRANSFORM

* ADD TRANSFORM

* ADD DOCSTRING AND TEST
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants