-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMC Inner kernel tuning #595
SMC Inner kernel tuning #595
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
==========================================
+ Coverage 99.16% 99.18% +0.01%
==========================================
Files 54 57 +3
Lines 2513 2563 +50
==========================================
+ Hits 2492 2542 +50
Misses 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Only minor comments.
…guaran/blackjax into carlosiguaran_smc_inner_kernel_tuning
…guaran/blackjax into carlosiguaran_smc_inner_kernel_tuning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Last bit of nitpick :-)
…guaran/blackjax into carlosiguaran_smc_inner_kernel_tuning
* inner kernel tuning, tests, and some common strategies * Adding imports * pre-commit * code review updates * Adding Chex tests * line alignment comment * Adding particles_as_rows test * Modifying implementation of particles_as_rows * pre-commit * change in inverse_mass_matrix from particles implementation * replacing particles_as_rows_test --------- Co-authored-by: Junpeng Lao <[email protected]>
See Design choice (c) of section 2.1.3 from https://arxiv.org/abs/1808.07730.
See sampling-notebook PR: blackjax-devs/sampling-book#49
Previously discussed here: #245
A few important guidelines and requirements before we can merge your PR:
main
commit;pre-commit
is installed and configured on your machine, and you ran it before opening the PR;