Extend Move SCP response and abort DcmSend associations on C-STORE I/O errors mid transfer #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extend DicoogleDcmSend to keep track of failed and skipped file transfers - propagate exception to caller upon fatal I/O error in DicoogleDcmSend - change MoveRSP to admit a response status other than success - refactor CallDCMSend into a method in CMoveServiceSCP - add sub-operation countings in response, and report warning status when suitable
- Status.ProcessingFailure and other constants in this class need to be complemented with the base error code
Enet4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two major concerns in the C-MOVE operation with Dicoogle:
Indefinite hanging
an edge case where a remote transfer association can hang indefinitely due to errors in the storage provider, such as corrupted storage data. Getting an
IOExceptionwhile invokingcstorewould result in the local store SCU proceeding to wait for a response from the SCP, even though it had not sent the final PData, resulting in both peers waiting for each other.The approach adopted here was to abort the association as soon as an
IOExceptionhappens.Opaque C-MOVE response
Moreover, this PR includes an extension to the C-MOVE SCP so that it also returns more accurate information about how the C-MOVE operation went, so that the C-MOVE SCU can more reliably understand what happened.
Cxxx, as mandated by the standard. Error ID and Error Comment may also be provided.B000.