Feat/use unique id to have valid label for attributes page 4088 #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…belongsto-support-PAGE-4109 feat: enabled resetting value of autocomplete
# [2.185.0](v2.184.0...v2.185.0) (2024-03-11) ### Features * enabled resetting value of autocomplete ([576a75b](576a75b))
…alues-PAGE-4132 Feat/laod hasmany pagevar values page 4132
…mponent so that it adheres to the WCAG standards
ewoutquax
reviewed
Mar 25, 2024
| @@ -268,6 +269,7 @@ | |||
| > | |||
| {labelText && !hideLabel && ( | |||
| <InputLabel | |||
| htmlFor={id} | |||
There was a problem hiding this comment.
ComponentID is shown in the snapshot as secret-id-do-not-use, but we do use it here.
I do not know exactly how valid the 'do not use'-warning is, but maybe we should take it seriously.
Alternative: make a page-wide counter-helper, which return a unique, incremented counter each time it is called. We can use the result of that counter, with a prefix, to generate unique for-ids.
Pro: this setup may also help for the iterated input-components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.